1322062 - Columns in the new Debugger can't be resized when dev tools is placed on the right side

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Richard Greenwood]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.75 Safari/537.36

Steps to reproduce:

1. Place the Developer Tools to the right side of the Firefox window
2. Resize the columns between sources, debugger and breakpoint panels


Actual results:

Center panel (debugger) "snaps" to a very narrow width and can not be changed.


Expected results:

Developer Tools panel columns widths should be user adjustable. Resizing panels widths works correctly when dev tools are below or detached, but not when on right. Tested only on xubuntu 16.04.

Comment 1

[[:Towkir] Ahmed]

It seems intentional to me.
Lets wait for developers decisions.

Comment 2

[Richard Greenwood]

(In reply to [:Towkir] Ahmed from comment #1)
> It seems intentional to me.
> Lets wait for developers decisions.

It's most certainly NOT intentional. I don't see how to upload a screen shot which would illustrate the problem. The debugger panel (middle panel) is unusable. On my laptop it only show 4 characters of each line. If you're not seeing the problem then it's probably platform dependent. I've got the same problem on my desktop & laptop, both running xubuntu 16.04, only computers I have access to.

Comment 3

[[:Towkir] Ahmed]

You can take a screenshot and attach it with this bug so that it becomes easier to understand the issue.
Thanks

Comment 4

[Richard Greenwood]

Attachment: dev tools, debugger can not be resized

When the dev tools are docked to the right the 3 panels can not be resized.

Comment 5

[Loic]

It's an issue with the new Debugger. I can't even resize the columns in the new Debugger when it is placed on the right side. Only the left edge (which owns to the entire dev tools "box") can be resized.

Comment 6

[Brian Grinstead [:bgrins]]

Needinfo to make sure this is on the radar for the new debugger frontend

Comment 7

[James Long (:jlongster)]

There was some work on a vertical layout at some point so it's probably related to that. I have no knowledge of it though, so assigning this to Jason.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Being tracked here: https://github.com/devtools-html/debugger.html/issues/1378

Comment 9

[Amit Zur]

From this PR https://github.com/devtools-html/devtools-core/pull/94 -

In split box, we calculate screenX and screenY with a consideration of the window's border. This is done by comparing window.outerWidth and window.innerWidth (or height).
When there are panels (e.g. devtools :) or bookmarks) the difference between outer and inner size is very large. So the split box breaks.

Neglecting the window's border is a small price to pay since it's around 5px (in Windows) compared to not being about to dock right (or dock bottom with a vertical flow).
The ideal solution would be to not use screenX and screenY, but I realize the tradeoff with not having to calculate relative coordinates of iframes.

Comment 10

[:Harald Kirschner :digitarald]

Fixed per last comment. Please re-open if you see otherwise.