1322301 - Add flags to GeneratedFiles in the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

Bug 1319345 added flags to GeneratedFiles objects. We need to support these in the tup backend to un-bust the application.ini file generation.

Comment 1

[Michael Shal [:mshal]]

Attachment: Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

Review commit: https://reviewboard.mozilla.org/r/97530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97530/

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8817101 [details]
Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

https://reviewboard.mozilla.org/r/97530/#review97922

::: python/mozbuild/mozbuild/backend/tup.py:248
(Diff revision 1)
>                  obj.outputs[0],
>                  '%s.pp' % obj.outputs[0], # deps file required
>              ])
>              full_inputs = [f.full_path for f in obj.inputs]
>              cmd.extend(full_inputs)
> +            cmd.extend([shell_quote(f) for f in obj.flags])

Might as well skip the temporary array here.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8817101 [details]
Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

https://reviewboard.mozilla.org/r/97530/#review97932

Comment 4

[Michael Shal [:mshal]]

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #2)
> > +            cmd.extend([shell_quote(f) for f in obj.flags])
> 
> Might as well skip the temporary array here.

Good catch - fixed!

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8817101 [details]
Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97530/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b3b26d63719
Add flags to GeneratedFiles in the tup backend; r=chmanchester

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b3b26d63719