Closed Bug 1322301 Opened 3 years ago Closed 3 years ago

Add flags to GeneratedFiles in the tup backend

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1319345 added flags to GeneratedFiles objects. We need to support these in the tup backend to un-bust the application.ini file generation.
Blocks: buildtup
Comment on attachment 8817101 [details]
Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

https://reviewboard.mozilla.org/r/97530/#review97922

::: python/mozbuild/mozbuild/backend/tup.py:248
(Diff revision 1)
>                  obj.outputs[0],
>                  '%s.pp' % obj.outputs[0], # deps file required
>              ])
>              full_inputs = [f.full_path for f in obj.inputs]
>              cmd.extend(full_inputs)
> +            cmd.extend([shell_quote(f) for f in obj.flags])

Might as well skip the temporary array here.
Comment on attachment 8817101 [details]
Bug 1322301 - Add flags to GeneratedFiles in the tup backend;

https://reviewboard.mozilla.org/r/97530/#review97932
Attachment #8817101 - Flags: review?(cmanchester) → review+
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #2)
> > +            cmd.extend([shell_quote(f) for f in obj.flags])
> 
> Might as well skip the temporary array here.

Good catch - fixed!
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b3b26d63719
Add flags to GeneratedFiles in the tup backend; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/6b3b26d63719
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.