about:profiles doesn't looks well on RTL builds

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Startup and Profile System
P5
normal
RESOLVED FIXED
5 months ago
17 days ago

People

(Reporter: tomer, Assigned: ItielMaN)

Tracking

({rtl})

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: good first bug, URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 months ago
The about:profile page is part of a new Profile Manager UI. This page is currently localized on Nightly, but doesn't display well because the page lacks dir=rtl.
(Reporter)

Updated

5 months ago
Summary: about:profiles doesn't have looks well on RTL builds → about:profiles doesn't looks well on RTL builds
(Reporter)

Updated

5 months ago
(Assignee)

Updated

5 months ago
Assignee: nobody → itiel_yn8
(Assignee)

Comment 1

5 months ago
Created attachment 8817246 [details] [diff] [review]
patch
(Reporter)

Comment 2

5 months ago
Comment on attachment 8817246 [details] [diff] [review]
patch

Great work, ItielMaN. I'll transform this change into a commit.
Attachment #8817246 - Attachment description: 1298688.patch → patch
Attachment #8817246 - Attachment is obsolete: true
Comment hidden (mozreview-request)
Priority: -- → P5
(Reporter)

Updated

4 months ago
Attachment #8817253 - Flags: review?(ehsan)
Comment on attachment 8817253 [details]
Bug 1322389 about:profiles doesn't looks well on RTL builds

https://reviewboard.mozilla.org/r/97624/#review99934

Thanks for the fix!
Attachment #8817253 - Flags: review?(ehsan) → review+
(Reporter)

Updated

4 months ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 5

4 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fe4d9b603a0
about:profiles doesn't looks well on RTL builds r=Ehsan
Keywords: checkin-needed

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8fe4d9b603a0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Updated

4 months ago
Depends on: 1329433
QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 53.0a1 (2016-12-07) (64 Bit) (Ar) on WIndows 7, 64 Bit!

This bug's fix is verified with latest Beta(Ar)!

Build ID   : 20170403072723
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170412]
You need to log in before you can comment on or make changes to this bug.