Closed Bug 1322500 Opened 4 years ago Closed 4 years ago

Use CanvasClient in WebRenderCanvasLayer

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: sotaro, Assigned: mtseng)

References

Details

Attachments

(3 files)

No description provided.
Per discussion with Sotaro, I'm working on using CanvasClient for WebRenderCanvasLayer currently. So I'm going to steal this bug.
Assignee: sotaro.ikeda.g → mtseng
Summary: Use TextureClient in WebRenderCanvasLayer → Use CanvasClient in WebRenderCanvasLayer
Having a workable patch for webgl but not for canvas2d. I'll upload patches once the 2d part is done.
I share many codes in ClientCanvasLayer when I try to use CanvasClient in WebRenderCanvasLayer. So I extracted
common functions to a based class which called ShareableCanvasLayer. This patch is going to land in m-c.
Attachment #8821419 - Flags: review?(sotaro.ikeda.g)
Following works on webrender branch.
Comment on attachment 8821419 [details] [diff] [review]
Introducing ShareableCanvasLayer.

Is it possible to create a patch by using |hg cp| like Bug 1316479 Comment 2?
Attachment #8821419 - Flags: review?(sotaro.ikeda.g) → review+
Sure, I'll use |hg cp| for creating a new patch.
MozReview-Commit-ID: I22lXigQHZM
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #8)
> Created attachment 8821971 [details] [diff] [review]
> Introducing ShareableCanvasLayer
> 
> MozReview-Commit-ID: I22lXigQHZM

This is patch which generated by |hg cp|
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c86f74a55fa8
Introducing ShareableCanvasLayer. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/c86f74a55fa8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Also need webrender part to make everything works. Keep this bug open.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/f7db1b467195
Using CanvasClient for WebRenderCanvasLayer. r=sotaro?
https://hg.mozilla.org/projects/graphics/rev/8ea83e47ef87
Mark some webgl tests which are passed now. r=gfx?
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.