Closed
Bug 1322500
Opened 9 years ago
Closed 9 years ago
Use CanvasClient in WebRenderCanvasLayer
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: sotaro, Assigned: mtseng)
References
Details
Attachments
(3 files)
|
28.38 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
|
7.87 KB,
patch
|
Details | Diff | Splinter Review | |
|
34.81 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Per discussion with Sotaro, I'm working on using CanvasClient for WebRenderCanvasLayer currently. So I'm going to steal this bug.
Assignee: sotaro.ikeda.g → mtseng
|
|
Assignee | |
Updated•9 years ago
|
Summary: Use TextureClient in WebRenderCanvasLayer → Use CanvasClient in WebRenderCanvasLayer
|
|
Assignee | |
Comment 2•9 years ago
|
||
Having a workable patch for webgl but not for canvas2d. I'll upload patches once the 2d part is done.
|
|
Assignee | |
Comment 3•9 years ago
|
||
I share many codes in ClientCanvasLayer when I try to use CanvasClient in WebRenderCanvasLayer. So I extracted
common functions to a based class which called ShareableCanvasLayer. This patch is going to land in m-c.
Attachment #8821419 -
Flags: review?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Following works on webrender branch.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Try link for first patch https://treeherder.mozilla.org/#/jobs?repo=try&revision=41f10654255f8c2e9e0ccace96368bd90c904260
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8821419 [details] [diff] [review]
Introducing ShareableCanvasLayer.
Is it possible to create a patch by using |hg cp| like Bug 1316479 Comment 2?
Attachment #8821419 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
Assignee | |
Comment 7•9 years ago
|
||
Sure, I'll use |hg cp| for creating a new patch.
|
|
Assignee | |
Comment 8•9 years ago
|
||
MozReview-Commit-ID: I22lXigQHZM
|
|
Assignee | |
Comment 9•9 years ago
|
||
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #8)
> Created attachment 8821971 [details] [diff] [review]
> Introducing ShareableCanvasLayer
>
> MozReview-Commit-ID: I22lXigQHZM
This is patch which generated by |hg cp|
|
|
Assignee | |
Comment 10•9 years ago
|
||
|
||
Comment 11•9 years ago
|
||
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c86f74a55fa8
Introducing ShareableCanvasLayer. r=sotaro
|
||
Comment 12•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
|
Assignee | |
Comment 13•9 years ago
|
||
Also need webrender part to make everything works. Keep this bug open.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 14•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b63b2bdf6310dd876f330f7257d32bd2669594b
Try with webrender part.
|
|
Assignee | |
Comment 15•9 years ago
|
||
|
|
||
Comment 16•9 years ago
|
||
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/f7db1b467195
Using CanvasClient for WebRenderCanvasLayer. r=sotaro?
https://hg.mozilla.org/projects/graphics/rev/8ea83e47ef87
Mark some webgl tests which are passed now. r=gfx?
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•