Minor cleanup in property_database.js for display:contents

RESOLVED FIXED in Firefox 53

Status

()

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Importance:
--
trivial
Status:
RESOLVED FIXED
Opened:
3 years ago
Updated:
3 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Version:
unspecified
Target:
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

fix
1.45 KB, patch
jeremychen
: review+
Details | Diff | Splinter Review
Assignee

Description

•
3 years ago 
No description provided.
Assignee

Comment 1

•
3 years ago
Posted patch fix — — Splinter Review 
Minor cleanup to follow-up from bug 1295788.  Just seems neater to list
all the values declaratively in one place.
Attachment #8817464 - Flags: review?(jeremychen)

Comment 2

•
3 years ago 
Comment on attachment 8817464 [details] [diff] [review]
fix

Looks good to me. Thank you for the cleanup. :-)
Attachment #8817464 - Flags: review?(jeremychen) → review+
 Assignee

Updated

•
3 years ago
Keywords: checkin-needed

Comment 4

•
3 years ago 
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/97ec33ac9322
Move 'contents' together with the other 'display' values rather than adding dynamically with JS. r=jeremychen
Keywords: checkin-needed

Comment 5

•
3 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/97ec33ac9322
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.