Closed
Bug 1322581
Opened 8 years ago
Closed 7 years ago
[geckoview] Move prompt-related delegate function from ChromeDelegate into PromptDelegate
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: snorp, Assigned: jchen)
References
Details
Attachments
(5 files)
12.00 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
16.36 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
19.68 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
36.66 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
37.45 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
And hook them up to Gecko.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
Remove the old ChromeDelegate interface, to be replaced by PromptDelegate in a future patch.
Attachment #8854547 -
Flags: review?(snorp)
Assignee | ||
Comment 2•7 years ago
|
||
Add a PromptDelegate interface that implements possible prompts shown by a GeckoView application. All prompt methods include a callback parameter for the implementation to call back to GeckoView with results from the prompt.
Attachment #8854548 -
Flags: review?(snorp)
Reporter | ||
Updated•7 years ago
|
Attachment #8854547 -
Flags: review?(snorp) → review+
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8854548 [details] [diff] [review] 2. Add PromptDelegate interface (v1) Review of attachment 8854548 [details] [diff] [review]: ----------------------------------------------------------------- I can't really tell of this is a complete interface for everything we need to expose, but it's certainly a good start.
Attachment #8854548 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Add an event listener for the GeckoView:Prompt event, which JS code will use to sent over prompt requests and to receive prompt results. Both global and per-GeckoView listeners are required because we may not know the origin GeckoView for certain prompts, so some prompts will not have an associated GeckoView. This is also the reason for having a static default PromptDelegate in additional to an instance per-GeckoView PromptDelegate. All prompts without associated GeckoViews are sent directly to the default PromptDelegate.
Attachment #8856578 -
Flags: review?(snorp)
Assignee | ||
Comment 5•7 years ago
|
||
Add the necessary XPCOM components to handle prompts for GeckoView. The JS code mostly package the prompts into GeckoView:Prompt events, and send them to the Java side if in parent process, or to the parent process if in child process.
Attachment #8856579 -
Flags: review?(snorp)
Reporter | ||
Updated•7 years ago
|
Attachment #8856578 -
Flags: review?(snorp) → review+
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8856579 [details] [diff] [review] 4. Add JS GeckoView prompt implementation (v1) Review of attachment 8856579 [details] [diff] [review]: ----------------------------------------------------------------- It may be a good idea to find a better reviewer for GeckoViewPrompt.js, but anything is better than nothing right now.
Attachment #8856579 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Add a sample implementation of PromptDelegate to GeckoView example.
Attachment #8858374 -
Flags: review?(snorp)
Reporter | ||
Updated•7 years ago
|
Attachment #8858374 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b408d1666080 1. Remove GeckoView.ChromeDelegate; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/1d518d531034 2. Add PromptDelegate interface; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/cb346aa4c851 3. Add event listener for GeckoView:Prompt event; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/a03fcccb6400 4. Add JS GeckoView prompt implementation; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/13fd2a40e7d6 5. Add PromptDelegate implementation to GeckoView example; r=snorp
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b408d1666080 https://hg.mozilla.org/mozilla-central/rev/1d518d531034 https://hg.mozilla.org/mozilla-central/rev/cb346aa4c851 https://hg.mozilla.org/mozilla-central/rev/a03fcccb6400 https://hg.mozilla.org/mozilla-central/rev/13fd2a40e7d6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•