1322701 - Title bar toggling button in customize mode on OS X misses image

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Comment 1

[:Gijs (he/him)]

CAN_DRAW_IN_TITLEBAR isn't defined in the OS X theme dir so the images never get shown.

Comment 2

[:Gijs (he/him)]

Attachment: define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,

Comment 3

[Julien Cristau [:jcristau]]

tracking for 52 as new regression

Comment 4

[Dão Gottwald [::dao]]

Comment on attachment 8817719 [details] [diff] [review]
define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,

Can you do this in browser/themes/moz.build similar to how we define it elsewhere?

Or maybe we can do this in browser/moz.build even? Not sure how exactly this stuff propagates.

Comment 5

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 8817719 [details] [diff] [review]
> define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,
> 
> Can you do this in browser/themes/moz.build similar to how we define it
> elsewhere?
> 
> Or maybe we can do this in browser/moz.build even? Not sure how exactly this
> stuff propagates.

I tried doing this in browser/themes with a copy-paste of what we do in browser/base, and that didn't seem to work. :-\

Comment 6

[Dão Gottwald [::dao]]

Comment on attachment 8817719 [details] [diff] [review]
define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,

Okay, let's do it like this for now since we want to uplift, although we should still look into consolidating this. Maybe a build system peer can help.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8817719 [details] [diff] [review]
define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,

Approval Request Comment
[Feature/Bug causing the regression]: bug 1302759
[User impact if declined]: titlebar toggling button misses an image
[Is this code covered by automated tests?]: no, styling-only change
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: yes, open customize mode on OS X and Windows and check the titlebar toggle button on the bottom left has an image
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial change to restore pre-bug-1302759 state of existing CSS by modifying a build define
[String changes made/needed]: nope

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/600a0d1afdf0
define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, r=dao

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/600a0d1afdf0

Comment 10

[Julien Cristau [:jcristau]]

Can somebody from QE verify this fix in nightly?  See the steps in comment 7.

Comment 11

[Alexandru Simonca [:asimonca], Release Desktop QA]

This is Verified Fixed in Nightly 53.0a1 (id: 20161215030215) on MacOs 10.12 Sierra.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8817719 [details] [diff] [review]
define CAN_DRAW_IN_TITLEBAR in the theme moz.build files,

theming fix for windows/osx, take in aurora52

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd0f0ac09dba

Comment 14

[Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA]

I have reproduced this issue using Firefox  53.0a1 (20161209030212) on Mac OS X 10.9.5.
I can confirm this issue is fixed, I verified using Firefox 52.0b1 on Mac OS X 10.9.5.