Closed
Bug 1322701
Opened 4 years ago
Closed 4 years ago
Title bar toggling button in customize mode on OS X misses image
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | + | verified |
firefox53 | --- | verified |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.47 KB,
patch
|
dao
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
CAN_DRAW_IN_TITLEBAR isn't defined in the OS X theme dir so the images never get shown.
Blocks: 1302759
status-firefox50:
--- → unaffected
status-firefox52:
--- → affected
tracking-firefox52:
--- → ?
Keywords: regressionwindow-wanted
Assignee | ||
Comment 2•4 years ago
|
||
Attachment #8817719 -
Flags: review?(dao+bmo)
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment 4•4 years ago
|
||
Comment on attachment 8817719 [details] [diff] [review] define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, Can you do this in browser/themes/moz.build similar to how we define it elsewhere? Or maybe we can do this in browser/moz.build even? Not sure how exactly this stuff propagates.
Attachment #8817719 -
Flags: review?(dao+bmo)
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > Comment on attachment 8817719 [details] [diff] [review] > define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, > > Can you do this in browser/themes/moz.build similar to how we define it > elsewhere? > > Or maybe we can do this in browser/moz.build even? Not sure how exactly this > stuff propagates. I tried doing this in browser/themes with a copy-paste of what we do in browser/base, and that didn't seem to work. :-\
Flags: needinfo?(dao+bmo)
Comment 6•4 years ago
|
||
Comment on attachment 8817719 [details] [diff] [review] define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, Okay, let's do it like this for now since we want to uplift, although we should still look into consolidating this. Maybe a build system peer can help.
Flags: needinfo?(dao+bmo)
Attachment #8817719 -
Flags: review+
Assignee | ||
Updated•4 years ago
|
Has Regression Range: --- → yes
Keywords: checkin-needed
Assignee | ||
Comment 7•4 years ago
|
||
str |
Comment on attachment 8817719 [details] [diff] [review] define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, Approval Request Comment [Feature/Bug causing the regression]: bug 1302759 [User impact if declined]: titlebar toggling button misses an image [Is this code covered by automated tests?]: no, styling-only change [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: yes, open customize mode on OS X and Windows and check the titlebar toggle button on the bottom left has an image [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: trivial change to restore pre-bug-1302759 state of existing CSS by modifying a build define [String changes made/needed]: nope
Attachment #8817719 -
Flags: approval-mozilla-aurora?
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/600a0d1afdf0 define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, r=dao
Keywords: checkin-needed
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/600a0d1afdf0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment 10•4 years ago
|
||
Can somebody from QE verify this fix in nightly? See the steps in comment 7.
Flags: qe-verify+
Flags: needinfo?(andrei.vaida)
Comment 11•4 years ago
|
||
This is Verified Fixed in Nightly 53.0a1 (id: 20161215030215) on MacOs 10.12 Sierra.
Comment 12•4 years ago
|
||
Comment on attachment 8817719 [details] [diff] [review] define CAN_DRAW_IN_TITLEBAR in the theme moz.build files, theming fix for windows/osx, take in aurora52
Flags: needinfo?(andrei.vaida)
Attachment #8817719 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/dd0f0ac09dba
Updated•4 years ago
|
Version: unspecified → 52 Branch
I have reproduced this issue using Firefox 53.0a1 (20161209030212) on Mac OS X 10.9.5. I can confirm this issue is fixed, I verified using Firefox 52.0b1 on Mac OS X 10.9.5.
You need to log in
before you can comment on or make changes to this bug.
Description
•