Closed Bug 1322800 Opened 5 years ago Closed 5 years ago

Remove NextFrameSeekTask

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: kaku, Assigned: kaku)

References

Details

Attachments

(14 files)

58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
58 bytes, text/x-review-board-request
jwwang
: review+
Details
No description provided.
Assignee: nobody → kaku
Blocks: 1318610
Depends on: 1322801
Depends on: 1323942
Comment on attachment 8819235 [details]
Bug 1322800 part 7 - move NextFrameSeekTask::NeedMoreVideo();

https://reviewboard.mozilla.org/r/98792/#review99330

The commit message contains unwanted lines.
Attachment #8819235 - Flags: review?(jwwang) → review+
Comment on attachment 8819235 [details]
Bug 1322800 part 7 - move NextFrameSeekTask::NeedMoreVideo();

https://reviewboard.mozilla.org/r/98792/#review99330

@@ What's that..., will remove them.
Comment on attachment 8819242 [details]
Bug 1322800 part 14 - remove SeekTask and NextFrameSeekTask;

https://reviewboard.mozilla.org/r/99080/#review99334
Attachment #8819242 - Flags: review?(jwwang) → review+
Comment on attachment 8819229 [details]
Bug 1322800 part 1 - move NextFrameSeekTask::Seek();

https://reviewboard.mozilla.org/r/98780/#review99336
Attachment #8819229 - Flags: review?(jwwang) → review+
Comment on attachment 8819230 [details]
Bug 1322800 part 2 - move NextFrameSeekTask::CalculateNewCurrentTime();

https://reviewboard.mozilla.org/r/98782/#review99338
Attachment #8819230 - Flags: review?(jwwang) → review+
Comment on attachment 8819231 [details]
Bug 1322800 part 3 - move NextFrameSeekTask::Handle{Audio,Video,Not}{Decoded,Waited}();

https://reviewboard.mozilla.org/r/98784/#review99340
Attachment #8819231 - Flags: review?(jwwang) → review+
Comment on attachment 8819232 [details]
Bug 1322800 part 4 - move NextFrameSeekTask::MaybeFinishSeek();

https://reviewboard.mozilla.org/r/98786/#review99342
Attachment #8819232 - Flags: review?(jwwang) → review+
Comment on attachment 8819233 [details]
Bug 1322800 part 5 - move NextFrameSeekTask::RequestVideoData();

https://reviewboard.mozilla.org/r/98788/#review99344
Attachment #8819233 - Flags: review?(jwwang) → review+
Comment on attachment 8819234 [details]
Bug 1322800 part 6 - move NextFrameSeekTask::Is{Audio,Video}SeekComplete();

https://reviewboard.mozilla.org/r/98790/#review99346
Attachment #8819234 - Flags: review?(jwwang) → review+
Comment on attachment 8819236 [details]
Bug 1322800 part 8 - move NextFrameSeekTask::IsVideoRequestPending();

https://reviewboard.mozilla.org/r/98794/#review99348
Attachment #8819236 - Flags: review?(jwwang) → review+
Comment on attachment 8819237 [details]
Bug 1322800 part 9 - move NextFrameSeekTask::NextFrameSeekTask();

https://reviewboard.mozilla.org/r/98796/#review99350
Attachment #8819237 - Flags: review?(jwwang) → review+
Comment on attachment 8819238 [details]
Bug 1322800 part 10 - use StateObject::{Audio,Video}Queue() to replate NextFrameSeekTask::m{Audio,Video}Queue;

https://reviewboard.mozilla.org/r/98798/#review99352
Attachment #8819238 - Flags: review?(jwwang) → review+
Comment on attachment 8819239 [details]
Bug 1322800 part 11 - use SeekingState::mSeekJob.mTarget to replace NextFrameSeekTask::mTarget;

https://reviewboard.mozilla.org/r/98800/#review99354
Attachment #8819239 - Flags: review?(jwwang) → review+
Comment on attachment 8819240 [details]
Bug 1322800 part 12 - move all SeekingState data members;

https://reviewboard.mozilla.org/r/98802/#review99356
Attachment #8819240 - Flags: review?(jwwang) → review+
Comment on attachment 8819241 [details]
Bug 1322800 part 13 - disconnect NextFrameSeekingState and SeekTask;

https://reviewboard.mozilla.org/r/98804/#review99358
Attachment #8819241 - Flags: review?(jwwang) → review+
Comment on attachment 8819241 [details]
Bug 1322800 part 13 - disconnect NextFrameSeekingState and SeekTask;

https://reviewboard.mozilla.org/r/98804/#review99366

::: dom/media/MediaDecoderStateMachine.cpp:1393
(Diff revision 1)
> +
> +    NS_IMETHOD Run()
> +    {
> +      if (!mIsCancelled) {
> +        auto currentTime = mStateObj->mCurrentTime;
> +        DiscardFrames(mStateObj->VideoQueue(), [currentTime] (int64_t aSampleTime) {

It seems that VisualStudio does not allow inner class to access protected member of the outer class' parent class.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc83ab1d21f7b86d24fee83010975509257be0b5&selectedJob=32817014
Try looks good, thanks for the review!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/46ccc52fb0d2
part 1 - move NextFrameSeekTask::Seek(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/4bb06a1689c0
part 2 - move NextFrameSeekTask::CalculateNewCurrentTime(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/9d669db8e5de
part 3 - move NextFrameSeekTask::Handle{Audio,Video,Not}{Decoded,Waited}(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/44a6aa7daa10
part 4 - move NextFrameSeekTask::MaybeFinishSeek(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/c315df18fcb1
part 5 - move NextFrameSeekTask::RequestVideoData(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/f508d130f769
part 6 - move NextFrameSeekTask::Is{Audio,Video}SeekComplete(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/72eee3d1f63e
part 7 - move NextFrameSeekTask::NeedMoreVideo(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/6d8def90f67c
part 8 - move NextFrameSeekTask::IsVideoRequestPending(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/5d46e89683d4
part 9 - move NextFrameSeekTask::NextFrameSeekTask(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/4c25211782ff
part 10 - use StateObject::{Audio,Video}Queue() to replate NextFrameSeekTask::m{Audio,Video}Queue; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/704a929bcd95
part 11 - use SeekingState::mSeekJob.mTarget to replace NextFrameSeekTask::mTarget; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/2cd7cbf856db
part 12 - move all SeekingState data members; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/da2d76e10cbf
part 13 - disconnect NextFrameSeekingState and SeekTask; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/77c3f2e77448
part 14 - remove SeekTask and NextFrameSeekTask; r=jwwang
Keywords: checkin-needed
thanks for landing this, on debug builds of linux there is an improvement in the measurement of num_constructors:
== Change summary for alert #4546 (as of December 18 2016 03:36 UTC) ==

Improvements:

  1%  compiler_metrics num_constructors linux32 debug     179 -> 178
  1%  compiler_metrics num_constructors linux64 debug     179 -> 178

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4546
Blocks: 1325003
You need to log in before you can comment on or make changes to this bug.