1322840 - Add nicer labels for the QR builds

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On the graphics branch we have some new build types for the QuantumRender work that's ongoing. I like nice labels so I'd like to label them appropriately in TH.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozilla/treeherder/pull/2024

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: pull request

Not sure what the process here is exactly. Other open PRs seem to have autolander-generated review requests but that didn't happen for mine.

Comment 3

[Ed Morley [:emorley]]

Should these be build variations shown on the same line as an existing platform, or on their own line? If on their own line (as the current PR does), I think a build option type (eg like opt/debug/asan) might be more appropriate to store the "QR" attribute.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I think they're probably better off as a separate platform, because they have their own opt/debug variants. They need to be shown on their own line because they have tests as well. See https://treeherder.mozilla.org/#/jobs?repo=graphics&revision=325896b10e7cb0323e9a4e6c81a41ab8424899bd for an example

Comment 5

[Ed Morley [:emorley]]

Ah if they have their own opt/debug variants then yes totally agree :-)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8817877 [details] [review]
pull request

While this works to get them nicely labeled, I would suggest putting them up with the other desktop platforms, instead of being at the bottom of the list. Either grouped together like you have them now (priorities 31-33, maybe?[1]), or line them up with the rest of the similar platforms (put the linux-qr job up with other linux64 jobs, same for osx and windows[2]).

Bug 1306132 will remove the need to manually assign these arbitrary priority numbers, but that's waiting for post-Hawaii reviews.

1. http://imgur.com/jwK4NDC
2. http://imgur.com/6e6WmZj

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Of those two screenshots I think the second is preferable to me. I'll update the PR.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Updated PR

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b9d2362e169783b864685cddcbc553163466bf4b
Bug 1322840 - Add nice labels for the QR builds on the graphics branch. (#2024) r=kwierso

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Nice, thanks!

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Quick after the fact driveby question: Should the Linux QR jobs be labeled as "Linux x64 QuantumRender" instead of just "Linux QuantumRender"?

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Whoops, you're right, I should have labelled in x64. I'll make a followup PR.

Comment 13

[GitHub Autolander Bot]

Attachment: [treeherder] staktrace:qr-fix > mozilla:master

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Follow-up

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8819290 [details] [review]
Follow-up

Oh hey this time the bot picked it up.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8819289 [details] [review]
[treeherder] staktrace:qr-fix > mozilla:master

Yeah, if your pull request's first commit's message includes "bug xyz", the attachment gets created automatically.

Comment 17

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/389405900531793b7a9a76ad83a5c26a2303e4b2
Bug 1322840 - Mark Linux QR build as x64 (#2028) r=kwierso