Closed Bug 1322840 Opened 4 years ago Closed 4 years ago

Add nicer labels for the QR builds

Categories

(Tree Management :: Treeherder, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(2 files, 1 obsolete file)

On the graphics branch we have some new build types for the QuantumRender work that's ongoing. I like nice labels so I'd like to label them appropriately in TH.
Attached file pull request
Not sure what the process here is exactly. Other open PRs seem to have autolander-generated review requests but that didn't happen for mine.
Attachment #8817877 - Flags: review?(wkocher)
Should these be build variations shown on the same line as an existing platform, or on their own line? If on their own line (as the current PR does), I think a build option type (eg like opt/debug/asan) might be more appropriate to store the "QR" attribute.
I think they're probably better off as a separate platform, because they have their own opt/debug variants. They need to be shown on their own line because they have tests as well. See https://treeherder.mozilla.org/#/jobs?repo=graphics&revision=325896b10e7cb0323e9a4e6c81a41ab8424899bd for an example
Ah if they have their own opt/debug variants then yes totally agree :-)
Comment on attachment 8817877 [details] [review]
pull request

While this works to get them nicely labeled, I would suggest putting them up with the other desktop platforms, instead of being at the bottom of the list. Either grouped together like you have them now (priorities 31-33, maybe?[1]), or line them up with the rest of the similar platforms (put the linux-qr job up with other linux64 jobs, same for osx and windows[2]).

Bug 1306132 will remove the need to manually assign these arbitrary priority numbers, but that's waiting for post-Hawaii reviews.

1. http://imgur.com/jwK4NDC
2. http://imgur.com/6e6WmZj
Attachment #8817877 - Flags: review?(wkocher) → review+
Of those two screenshots I think the second is preferable to me. I'll update the PR.
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b9d2362e169783b864685cddcbc553163466bf4b
Bug 1322840 - Add nice labels for the QR builds on the graphics branch. (#2024) r=kwierso
Nice, thanks!
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Quick after the fact driveby question: Should the Linux QR jobs be labeled as "Linux x64 QuantumRender" instead of just "Linux QuantumRender"?
Flags: needinfo?(bugmail)
Whoops, you're right, I should have labelled in x64. I'll make a followup PR.
Flags: needinfo?(bugmail)
Attached file Follow-up (obsolete) —
Comment on attachment 8819290 [details] [review]
Follow-up

Oh hey this time the bot picked it up.
Attachment #8819290 - Attachment is obsolete: true
Attachment #8819289 - Flags: review?(wkocher)
Comment on attachment 8819289 [details] [review]
[treeherder] staktrace:qr-fix > mozilla:master

Yeah, if your pull request's first commit's message includes "bug xyz", the attachment gets created automatically.
Attachment #8819289 - Flags: review?(wkocher) → review+
You need to log in before you can comment on or make changes to this bug.