1322858 - Implement AudioWorkletGlobalScope

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

This is somehow needed for having AudioWorkletGlobalScope.
In our current implementation, WorkletGlobalScope is a global scope, but in the spec, it's not. There are other interfaces extending WorkletGlobalScope such as AudioWorkletGlobalScope, FakeWorkletGlobalScope and the houdini one.

With this bug I want to implement this FakeWorkletGlobalScope and improve our test cases.

Maybe, we can also make FakeWorkletGlobalScope to run in a different thread for testing the CC/GC.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: aw_0_fakeWorklet.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8817829 [details] [diff] [review]
aw_0_fakeWorklet.patch

FakeWorklet stuff is in non-normative example section of the spec. Why would we want it?

https://drafts.css-houdini.org/worklets/#examples


I don't think we should to add this. Better would be to add the AudioWorkletGlobalScope, even if not all the features were implemented immediately. And of course behind some flag.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: aw_W1_global.patch

This is not going to be exposed to content soon.
But I need it in order to continue the AudioWorklet implementation.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8817977 [details] [diff] [review]
aw_W1_global.patch

ok, preliminary patch, and main thread only.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed5c93dfd7dd
Implement AudioWorkletGlobalScope - main-thread only - not meant to be exposed yet, r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ed5c93dfd7dd

Comment 7

[Boris Zbarsky [:bzbarsky]]

AudioWorkletGlobalScope.webidl claims the origin of the file is https://www.w3.org/TR/worklets-1/#fakeworkletglobalscope but that spec doesn't define AudioWorkletGlobalScope at all.  Should that be linking to https://webaudio.github.io/web-audio-api/#AudioWorkletGlobalScope or something?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84af9d1e82d1
Fix the URL of the AudioWorklet spec in webidl files, r=me

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/84af9d1e82d1

Comment 10

[Arnaud Bienner]

FYI AudioWorkletGlobalScope specficiation has changed since this was shipped.
It now has the following new attributes:
  readonly attribute unsigned long long currentFrame;
  readonly attribute double currentTime;
  readonly attribute float sampleRate;

I will update the webidl files as part of bug 1458446.

Comment 11

[Eric Shepherd [:sheppy]]

Documentation team note: AudioWorklet is currently not expected to ship enabled by default until sometime early in 2019. Given that and some things which are still in flux, we are holding off on documenting it until it’s closer to ready. See bug 1473176, “Document AudioWorklet”.