1322922 - Addon doorhanger icon is black instead of grey

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Johann Hofmann [:johannh]]

See screenshots. This should be fixed and uplifted to Aurora. I know there's some relationship to bug 1304343 but the attached patch doesn't look like it fixes the issue. Dao, do you know more about that?

Comment 1

[Johann Hofmann [:johannh]]

Attachment: release

Comment 2

[Johann Hofmann [:johannh]]

Attachment: aurora

Comment 3

[roxleitan]

Last good revision: c0ca8b0d966ee28bc6542a762f8a592cf76054d8
First bad revision: a481cba452933d5e7571fce7733b1ad7d41f493b

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c0ca8b0d966ee28bc6542a762f8a592cf76054d8&tochange=a481cba452933d5e7571fce7733b1ad7d41f493b

Comment 4

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Recent regression in primary UI appearance.

Comment 5

[Julien Cristau [:jcristau]]

tracking for 52 as new regression

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1322922 - Use icon-colors.inc.svg in addon-install-anchor.svg.

Review commit: https://reviewboard.mozilla.org/r/104164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104164/

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8826143 [details]
Bug 1322922 - Use icon-colors.inc.svg in addon-install-anchor.svg.

https://reviewboard.mozilla.org/r/104164/#review104924

Looks good, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32bc131f9812
Use icon-colors.inc.svg in addon-install-anchor.svg. r=johannh

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8826143 [details]
Bug 1322922 - Use icon-colors.inc.svg in addon-install-anchor.svg.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1304708
[User impact if declined]: see attachment 8817910 [details]
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: can be reproduced by installing an add-on from AMO
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward update to an SVG file that I missed in bug 1304708
[String changes made/needed]: /

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32bc131f9812

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8826143 [details]
Bug 1322922 - Use icon-colors.inc.svg in addon-install-anchor.svg.

fix addon doorhanger appearance in aurora52

Comment 12

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be6b93fc358202fd89734172058293cd764e75b5

Comment 13

[Matthew N. [:MattN]]

Screenshots of the change: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=97d6f73643940256c0eb61e384c49bf6f6c49847&newProject=mozilla-central&newRev=91f5293e9a89056565493ed5073c3842b0ee9fdc&filter=permissionPrompts_.*_addons

Comment 14

[Simona Badau, Desktop QA]

Attachment: missingAddonDoorhanger.png

Reproduced the initial issue on Aurora 52.0a2 (Build ID: 20161211004007).

I can confirm that the Addon doorhanger icon is grey when using the latest Aurora 53.0a2 (Build ID: 20170131004003) On Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11. 

But, I found a situation when the add-on doorhanger icon is not displayed at all when the add-on that is installed it's saved locally. Is this expected in any way? Please see the screenshot for more details.

Also, please note that the initial issue is reproducible also on the latest Firefox 51.0.1 (Build ID: 20170125094131)

Comment 15

[Johann Hofmann [:johannh]]

This is another side effect of bug 1300755.

Comment 16

[:Paolo Amadini]

Ah, thanks for flagging this Johann. I'll make sure to include the invalid pageproxystate caused by drag and drop or new tabs with "file:" URLs at least in manual testing for bug 1328304.

Comment 17

[:Paolo Amadini]

And I forgot to say thanks to Simona for finding the bug, although I wanted to :-)

Comment 18

[Johann Hofmann [:johannh]]

Yes, thank you, that was a good find!

Comment 19

[Simona Badau, Desktop QA]

Paolo, will the issue mentioned in Comment 14 going to be fixed in Bug 1328304 (can I add a comment with the scenario on it)? Or should I file a new bug for that?

Comment 20

[:Paolo Amadini]

To clarify, it's quite likely that this will continue to be the expected behavior even after bug 1328304 is fixed, so there is no need to file a bug. I'll have to make sure to test this scenario at least manually though.

Comment 21

[Surentharan]

[bugday-20170201]

Comment 22

[Simona Badau, Desktop QA]

Thank you Paolo for clarifying things for me. 

Based on Comment 14 and on Comment 20, setting the tracking flag for status-firefox53:	to verified.