Closed Bug 1304343 Opened 3 years ago Closed 3 years ago

Notification anchor and blocked permission icons should use the same opacity as other icons in the identity block

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Followup from bug 1303291.
Summary: Notification anchor icons should use the same opacity as other icons in the identity block → Notification anchor and blocked permission icons should use the same color and opacity as other icons in the identity block
Priority: -- → P3
Priority: P3 → P2
So the reason why these icons have lower opacity is that we want to increase their opacity on hover. Presumably once we've made these notifications modal, the anchor icons won't need the hover effect anymore. (In fact, we probably wouldn't need the anchor icons at all anymore and could just anchor the notifications on the identity icon...)
Summary: Notification anchor and blocked permission icons should use the same color and opacity as other icons in the identity block → Notification anchor and blocked permission icons should use the same opacity as other icons in the identity block
Depends on: 1304708
Attached patch patchSplinter Review
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8815694 - Flags: review?(jkt)
I think there is going to be another move to make the icons as part of the "(i)" identity icon and also viewing multiple permissions as part of that work, however until we have that the user could be faced with multiple notifications which they might want to choose between:

1. Visit permission.site
2. Click notifications
3. Click location

User sees two permissions to choose from.

It appears the following selector doesn't work however something like this might be more suitable:
  .notification-anchor-icon:not(.plugin-blocked):not(:hover):not([selected="true"]) {
Flags: needinfo?(dao+bmo)
(In reply to Jonathan Kingston [:jkt] from comment #3)
> I think there is going to be another move to make the icons as part of the
> "(i)" identity icon and also viewing multiple permissions as part of that
> work, however until we have that the user could be faced with multiple
> notifications which they might want to choose between:
> 
> 1. Visit permission.site
> 2. Click notifications
> 3. Click location
> 
> User sees two permissions to choose from.

This seems like an edge case. Do we really need to keep the opacity change on hover for that?
Flags: needinfo?(dao+bmo) → needinfo?(jkt)
Well that would make the default view not opaque and only allow a hover on the unselected icon... I defer however to :past who may be able to route this to someone with the sign off on the new permissions project.
Flags: needinfo?(jkt) → needinfo?(past)
I'm sympathetic to jkt's argument, but ultimately it's phlsa's call.
Flags: needinfo?(past) → needinfo?(philipp)
Assignee: dao+bmo → nobody
Status: ASSIGNED → NEW
Attachment #8815694 - Flags: review?(jkt)
No longer blocks: 1322922
I agree with Dão here - the difference is so subtle that it just looks like noise anyway. Also, since all icons in there can be clicked, it makes sense for all of them to have the same opacity.
Flags: needinfo?(philipp)
Thanks Philipp, Dão could you land your patch then? r=me.
Flags: needinfo?(dao+bmo)
Assignee: nobody → dao+bmo
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daa9f9d628b6
Remove hover effect from notification anchor icons. r=past
https://hg.mozilla.org/mozilla-central/rev/daa9f9d628b6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Let it ride the train.
You need to log in before you can comment on or make changes to this bug.