1304343 - Notification anchor and blocked permission icons should use the same opacity as other icons in the identity block

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Dão Gottwald [:dao]]

Followup from bug 1303291.

Comment 1

[Dão Gottwald [:dao]]

So the reason why these icons have lower opacity is that we want to increase their opacity on hover. Presumably once we've made these notifications modal, the anchor icons won't need the hover effect anymore. (In fact, we probably wouldn't need the anchor icons at all anymore and could just anchor the notifications on the identity icon...)

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Jonathan Kingston [:jkt] he/him]

I think there is going to be another move to make the icons as part of the "(i)" identity icon and also viewing multiple permissions as part of that work, however until we have that the user could be faced with multiple notifications which they might want to choose between:

1. Visit permission.site
2. Click notifications
3. Click location

User sees two permissions to choose from.

It appears the following selector doesn't work however something like this might be more suitable:
  .notification-anchor-icon:not(.plugin-blocked):not(:hover):not([selected="true"]) {

Comment 4

[Dão Gottwald [:dao]]

(In reply to Jonathan Kingston [:jkt] from comment #3)
> I think there is going to be another move to make the icons as part of the
> "(i)" identity icon and also viewing multiple permissions as part of that
> work, however until we have that the user could be faced with multiple
> notifications which they might want to choose between:
> 
> 1. Visit permission.site
> 2. Click notifications
> 3. Click location
> 
> User sees two permissions to choose from.

This seems like an edge case. Do we really need to keep the opacity change on hover for that?

Comment 5

[Jonathan Kingston [:jkt] he/him]

Well that would make the default view not opaque and only allow a hover on the unselected icon... I defer however to :past who may be able to route this to someone with the sign off on the new permissions project.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I'm sympathetic to jkt's argument, but ultimately it's phlsa's call.

Comment 7

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I agree with Dão here - the difference is so subtle that it just looks like noise anyway. Also, since all icons in there can be clicked, it makes sense for all of them to have the same opacity.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Thanks Philipp, Dão could you land your patch then? r=me.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daa9f9d628b6
Remove hover effect from notification anchor icons. r=past

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/daa9f9d628b6

Comment 11

[Matthew N. [:MattN]]

Screenshots of the change: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=97d6f73643940256c0eb61e384c49bf6f6c49847&newProject=mozilla-central&newRev=91f5293e9a89056565493ed5073c3842b0ee9fdc&filter=permissionPrompts

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Let it ride the train.