Closed
Bug 1322953
Opened 8 years ago
Closed 8 years ago
Remove padding-inline-end from #nav-bar-customization-target
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
673 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Leftover from bug 1322430. Removing this padding somehow causes the search bar to be pushed off the toolbar into the overflow panel, which causes failures with tests that access the search bar.
|
Assignee | |
Comment 1•8 years ago
|
||
Jared, since you wrote the toolbar overflow code, any idea what's going on here?
Flags: needinfo?(jaws)
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 2•8 years ago
|
||
Hitting the same failure on Linux in bug 1323001.
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8ed5a7be683af8322e7bc21df732aad283a3e59a&selectedJob=40524593
https://public-artifacts.taskcluster.net/N6vyQylOTh-GkOTHqoIYFA/0/public/test_info//mozilla-test-fail-screenshot_fq8Mzk.png
|
|
Assignee | |
Comment 3•8 years ago
|
||
I've identified browser_newWindowDrop.js as the culprit and filed bug 1323276.
Assignee: nobody → dao+bmo
Flags: needinfo?(jaws)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8817934 [details] [diff] [review]
strawman patch
Gijs basically r+'d this in bug 1322430 already.
Attachment #8817934 -
Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06f516403cf4
Remove padding-inline-end from #nav-bar-customization-target. r=gijs
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in
before you can comment on or make changes to this bug.
Description
•