The default bug view has changed. See this FAQ.

Port Bug 1323042 to mailnews: Remove calls to MOZ_COUNT_CTOR and MOZ_COUNT_DTOR

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: Jorg K (GMT+1), Assigned: Jorg K (GMT+1))

Tracking

53 Branch
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
See for example here:
https://hg.mozilla.org/mozilla-central/rev/f347515b29ae#l1.12
(Assignee)

Comment 1

3 months ago
The compile errors I can see on the tree are in:
nsMsgThread.cpp 3x
nsImapMailFolder.cpp 2x
nsNewsFolder.cpp 2x

There are more uses in mailnews/ in
nsAbWinHelper.cpp
nsMapiAddressBook.cpp
nsWabAddressBook.cpp
nsMsgCopyService.cpp
nsMsgKeySet.cpp
nsMsgLineBuffer.cpp

morkStore.cpp

Right now I'm doing a local compile with only the first three files changed. Oops, just failed on morkStore.cpp. I'll proceed incrementally.
(Assignee)

Updated

3 months ago
Version: 52 Branch → 53 Branch
(Assignee)

Comment 2

3 months ago
Created attachment 8818513 [details] [diff] [review]
1323406-ctor-dtor.patch

With this patch, the build went through.

Try here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9277d35349e80bca18a7e4eb08a9cea4cba99f97
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 months ago
https://hg.mozilla.org/comm-central/rev/f10e840262ddbbad24db1642906cf6643622665f

Apparently only classes derived from nsISupports needed to have these calls removed.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

Updated

3 months ago
Blocks: 1323042
You need to log in before you can comment on or make changes to this bug.