1323544 - Rewrite autoland history to remove revision 47b072202511

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1321184 +++

Bug 1323521 landed a commit that mass-changed the line endings of nsWindow.cpp, which is causing to cause some serious headaches for blame.
https://hg.mozilla.org/integration/autoland/rev/47b072202511

This seems like something that's potentially worthy of history rewriting. I've closed autoland for now while we discuss.

Hal, given that Greg is in PTO, can you chime in?

Comment 1

[Mike Hommey [:glandium]]

For what it's worth, mercurial's blame has an option to ignore whitespace changes. If it could be made the default, especially on hgweb, I'd argue that would not require history rewriting.

Comment 2

[Justin Wood (:Callek)]

(In reply to Mike Hommey [:glandium] from comment #1)
> For what it's worth, mercurial's blame has an option to ignore whitespace
> changes. If it could be made the default, especially on hgweb, I'd argue
> that would not require history rewriting.

Whitespace changes however, are relevant in python files, (which a lot of m-c is) though line endings are not that relevant. I'd be less eager to ignore whitespace for this.

Also of note, is that autoland has been explicitly advertised as "do not pull from me" in the past, so a rewrite on autoland shouldn't be as impactful as one may fear, greg even has code to do a rewrite-backout of sorts.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

fubar, Hal says you're a better person to ping here.

Comment 4

[Gregory Szorc [:gps]]

$ sudo /var/hg/venv_tools/bin/hg --config extensions.drop=/var/hg/vct.tmp/hgext/drop drop --config ui.username='Gregory Szorc <[e-mail]>'  47b072202511
dropping 47b072202511 (requested explicitly): Bug 1323521: Prevent Windows touchscreen support from instantiating a11y; r=jimm
grafted bc26b2f7b6e7 -> afe3fed7c351: Bug 1319587 - shrink radius length of video control thumb spread. r=jaws
creating new pushlog entry #35083 by [e-mail] from entry #35082

View your change here:
  https://hg.mozilla.org/integration/autoland/rev/afe3fed7c351a0af57871d1f4550c57b9b772ff1

Follow the progress of your build on Treeherder:
  https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=afe3fed7c351a0af57871d1f4550c57b9b772ff1
recorded changegroup in replication log in 0.002s
recorded updates to obsolete in replication log in 0.001s

Note: there is still an open issue where the tree closure hook needs to be disabled when `drop` runs, otherwise you corrupt the repo. I remembered this time and didn't corrupt the repo.

I think you can reopen the tree.