Maintain binary compatibility for Thunderbird 45 after Bug 881832

RESOLVED FIXED in Thunderbird 45.0

Status

Thunderbird
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

45 Branch
Thunderbird 45.0

Thunderbird Tracking Flags

(thunderbird_esr4550+ fixed, thunderbird52 unaffected)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Bug 881832 added changes to nsIContentViewer.idl and nsIBaseWindow.idl, breaking compatibility on the mozilla-esr45 branch. Thunderbird is committed to maintaining binary compatibility for TB 45 releases, so we need to land a patch on THUNDERBIRD_45_VERBRANCH to maintain binary compatibility.
(Assignee)

Updated

a year ago
Depends on: 881832
(Assignee)

Comment 1

a year ago
Created attachment 8818828 [details] [diff] [review]
Restore .idl to original, and add esr45-specific new interfaces

I'm not sure if you are comfortable with the review or not. Though long, the patch is very straightforward.
Attachment #8818828 - Flags: review?(jorgk)

Comment 2

a year ago
Comment on attachment 8818828 [details] [diff] [review]
Restore .idl to original, and add esr45-specific new interfaces

Review of attachment 8818828 [details] [diff] [review]:
-----------------------------------------------------------------

This looks straight forward. I'm sure you'll test/have tested that this "refactoring" actually does what it intends to do.

You copied a few lines which had trailing spaces, but I don't think its worth complaining about those individually.

You have my OK to land this with r=jorgk.

There are two points to keep in mind:
1) I'm not really qualified to review this, so you might want to get a second opinion, up to you.
2) How do I say it nicely: TB 45.x is not my highest priority and I trust that you've done the right thing.

How does that work on https://treeherder.mozilla.org/#/jobs?repo=comm-esr45? Which m-esr45 does it use? The "official" one or our release branch? How do we check that this patch doesn't cause any failures?
Attachment #8818828 - Flags: review?(jorgk) → review+
(Assignee)

Comment 3

a year ago
"How do we check that this patch doesn't cause any failures?"

For test failures, the only viable path at the moment is to land it, then start a compile on c-esr45.  I've done that in the past as a pseudo try server. I wanted to land this first before I land other patches so that we could see those tests.
(Assignee)

Comment 4

a year ago
https://hg.mozilla.org/releases/mozilla-esr45/rev/91d2cfeae195
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-thunderbird52: --- → unaffected
status-thunderbird_esr45: --- → fixed
tracking-thunderbird_esr45: --- → 50+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0

Comment 5

a year ago
How about answering my other questions:

How does that work on https://treeherder.mozilla.org/#/jobs?repo=comm-esr45?
Which m-esr45 does it use?
The "official" one or our release branch?

And how do you tell it which branch to use?

Sorry, I need to know for ESR 52.
Flags: needinfo?(rkent)
(Assignee)

Comment 6

a year ago
How does that work on https://treeherder.mozilla.org/#/jobs?repo=comm-esr45? Which m-esr45 does it use? The "official" one or our release branch?

Treeherder uses a specified version of m-esr45, which is set somewhere to THUNDERBIRD_45_VERBRANCH

Now you will want to know where that "Somewhere" is. Hmmm. Search in comm-esr45 for THUNDERBIRD_45_VERBRANCH and you will see the affected spots. Note this also affects checkouts done with client.py which is the correct way to do it.
Flags: needinfo?(rkent)
You need to log in before you can comment on or make changes to this bug.