Closed Bug 1323662 Opened 5 years ago Closed 5 years ago

stylo: several tests panic with "Snapshots should be expanded by the caller"

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: heycam, Assigned: bholley)

References

Details

thread '<unnamed>' panicked at 'Snapshots should be expanded by the caller', /z/stylo/hg-incubator/servo/components/style/traversal.rs:382
stack backtrace:
   1:     0x7fffea9ba11f - std::sys::backtrace::tracing::imp::write::hd6ece0fd16ebfe06
   2:     0x7fffea9c967d - std::panicking::default_hook::{{closure}}::h523f1cb7f97bbc83
   3:     0x7fffea9c6bda - std::panicking::default_hook::hc3c81c24cdcc8c31
   4:     0x7fffea9c71d8 - std::panicking::rust_panic_with_hook::hf4b937f570e0ba05
   5:     0x7fffe9d4dda3 - std::panicking::begin_panic::hcb26c0e753df7acf
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libstd/panicking.rs:413
   6:     0x7fffe9df1c12 - style::traversal::recalc_style_at::hac1f02916e311070
                        at /z/stylo/hg-incubator/obj/toolkit/library/rust/<std macros>:3
   7:     0x7fffe9eae406 - Servo_ResolveStyle
                        at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:836
   8:     0x7fffe6d26d48 - _ZN7mozilla13ServoStyleSet10GetContextEP10nsIContentP14nsStyleContextP7nsIAtomNS_20CSSPseudoElementTypeENS_20ConsumeStyleBehaviorENS_19LazyComputeBehaviorE
                        at /z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:113
   9:     0x7fffe6d26c61 - _ZN7mozilla13ServoStyleSet15ResolveStyleForEPNS_3dom7ElementEP14nsStyleContextNS_20ConsumeStyleBehaviorENS_19LazyComputeBehaviorE
                        at /z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:98
  10:     0x7fffe5dcbcc2 - _ZN7mozilla14StyleSetHandle3Ptr15ResolveStyleForEPNS_3dom7ElementEP14nsStyleContextNS_20ConsumeStyleBehaviorENS_19LazyComputeBehaviorE
                        at /z/stylo/hg-incubator/obj/dist/include/mozilla/StyleSetHandleInlines.h:86
  11:     0x7fffe6fd3f31 - _ZL39GetPropagatedScrollbarStylesForViewportP13nsPresContextPN7mozilla15ScrollbarStylesE
                        at /z/stylo/hg-incubator/layout/base/nsPresContext.cpp:1388
  12:     0x7fffe6fd3d97 - _ZN13nsPresContext37UpdateViewportScrollbarStylesOverrideEv
                        at /z/stylo/hg-incubator/layout/base/nsPresContext.cpp:1434
  13:     0x7fffe6f6c909 - _ZN21nsCSSFrameConstructor14ContentRemovedEP10nsIContentS1_S1_NS_11RemoveFlagsEPbPS1_
                        at /z/stylo/hg-incubator/layout/base/nsCSSFrameConstructor.cpp:8289
  14:     0x7fffe6efaf2c - _ZN7mozilla9PresShell14ContentRemovedEP11nsIDocumentP10nsIContentS4_iS4_
                        at /z/stylo/hg-incubator/layout/base/PresShell.cpp:4433
  15:     0x7fffe493bf00 - _ZN11nsNodeUtils14ContentRemovedEP7nsINodeP10nsIContentiS3_
                        at /z/stylo/hg-incubator/dom/base/nsNodeUtils.cpp:226
  16:     0x7fffe493bcaf - _ZN7nsINode15doRemoveChildAtEjbP10nsIContentR19nsAttrAndChildArray
                        at /z/stylo/hg-incubator/dom/base/nsINode.cpp:1906
  17:     0x7fffe4781507 - _ZN7mozilla3dom17FragmentOrElement13RemoveChildAtEjb
                        at /z/stylo/hg-incubator/dom/base/FragmentOrElement.cpp:1159
  18:     0x7fffe4936688 - _ZN7nsINode11RemoveChildERS_RN7mozilla11ErrorResultE
                        at /z/stylo/hg-incubator/dom/base/nsINode.cpp:570
  19:     0x7fffe4cfdd0e - _ZN7mozilla3dom11NodeBindingL11removeChildEP9JSContextN2JS6HandleIP8JSObjectEEP7nsINodeRK19JSJitMethodCallArgs
                        at /z/stylo/hg-incubator/obj/dom/bindings/NodeBinding.cpp:809
  20:     0x7fffe58aa6f1 - _ZN7mozilla3dom20GenericBindingMethodEP9JSContextjPN2JS5ValueE
                        at /z/stylo/hg-incubator/dom/bindings/BindingUtils.cpp:2886
  21:     0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE
                        at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239
  22:     0x7fffe968b46f - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:457
  23:     0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502
  24:     0x7fffe968b66c - _ZN2js13CallFromStackEP9JSContextRKN2JS8CallArgsE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:508
  25:     0x7fffe967fe75 - _ZL9InterpretP9JSContextRN2js8RunStateE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:2919
  26:     0x7fffe96752cf - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:403
  27:     0x7fffe968b567 - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:475
  28:     0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502
  29:     0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521
  30:     0x7fffe937d1af - _ZN2JS4CallEP9JSContextNS_6HandleINS_5ValueEEES4_RKNS_16HandleValueArrayENS_13MutableHandleIS3_EE
                        at /z/stylo/hg-incubator/js/src/jsapi.cpp:2830
  31:     0x7fffe554405e - _ZN7mozilla3dom19EventHandlerNonNull4CallEP9JSContextN2JS6HandleINS4_5ValueEEERNS0_5EventENS4_13MutableHandleIS6_EERNS_11ErrorResultE
                        at /z/stylo/hg-incubator/obj/dom/bindings/EventHandlerBinding.cpp:259
  32:     0x7fffe5b8575f - _ZN7mozilla3dom19EventHandlerNonNull4CallIP11nsISupportsEEvRKT_RNS0_5EventEN2JS13MutableHandleINSA_5ValueEEERNS_11ErrorResultEPKcNS0_14CallbackObject17ExceptionHandlingEP13JSCompartment
                        at /z/stylo/hg-incubator/obj/dist/include/mozilla/dom/EventHandlerBinding.h:361
  33:     0x7fffe5b761c0 - _ZN7mozilla14JSEventHandler11HandleEventEP11nsIDOMEvent
                        at /z/stylo/hg-incubator/dom/events/JSEventHandler.cpp:214
  34:     0x7fffe5b60890 - _ZN7mozilla20EventListenerManager18HandleEventSubTypeEPNS0_8ListenerEP11nsIDOMEventPNS_3dom11EventTargetE
                        at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1133
  35:     0x7fffe5b60fbd - _ZN7mozilla20EventListenerManager19HandleEventInternalEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus
                        at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1286
  36:     0x7fffe5b8af7c - _ZN7mozilla20EventListenerManager11HandleEventEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus
                        at /z/stylo/hg-incubator/obj/dist/include/mozilla/EventListenerManager.h:374
  37:     0x7fffe5b7dd37 - _ZN7mozilla20EventTargetChainItem11HandleEventERNS_21EventChainPostVisitorERNS_19ELMCreationDetectorE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:314
  38:     0x7fffe5b58809 - _ZN7mozilla20EventTargetChainItem22HandleEventTargetChainER8nsTArrayIS0_ERNS_21EventChainPostVisitorEPNS_24EventDispatchingCallbackERNS_19ELMCreationDetectorE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:463
  39:     0x7fffe5b59dde - _ZN7mozilla15EventDispatcher8DispatchEP11nsISupportsP13nsPresContextPNS_11WidgetEventEP11nsIDOMEventP13nsEventStatusPNS_24EventDispatchingCallbackEP8nsTArrayIPNS_3dom11EventTargetEE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:820
  40:     0x7fffe6f7eef4 - _ZN16nsDocumentViewer12LoadCompleteE8nsresult
                        at /z/stylo/hg-incubator/layout/base/nsDocumentViewer.cpp:1024
  41:     0x7fffe772771c - _ZN10nsDocShell11EndPageLoadEP14nsIWebProgressP10nsIChannel8nsresult
                        at /z/stylo/hg-incubator/docshell/base/nsDocShell.cpp:7571
  42:     0x7fffe77259d2 - _ZN10nsDocShell13OnStateChangeEP14nsIWebProgressP10nsIRequestj8nsresult
                        at /z/stylo/hg-incubator/docshell/base/nsDocShell.cpp:7375
  43:     0x7fffe3f27ccd - _ZN11nsDocLoader19DoFireOnStateChangeEP14nsIWebProgressP10nsIRequestRi8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:1255
  44:     0x7fffe3f277a8 - _ZN11nsDocLoader18doStopDocumentLoadEP10nsIRequest8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:840
  45:     0x7fffe3f2626e - _ZN11nsDocLoader16DocLoaderIsEmptyEb
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:730
  46:     0x7fffe3f271ab - _ZN11nsDocLoader13OnStopRequestEP10nsIRequestP11nsISupports8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:612
  47:     0x7fffe2c4798e - _ZN7mozilla3net11nsLoadGroup13RemoveRequestEP10nsIRequestP11nsISupports8nsresult
                        at /z/stylo/hg-incubator/netwerk/base/nsLoadGroup.cpp:633
  48:     0x7fffe48a9dcf - _ZN10nsDocument15DoUnblockOnloadEv
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:8622
  49:     0x7fffe48a9b8c - _ZN10nsDocument13UnblockOnloadEb
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:8550
  50:     0x7fffe489ab72 - _ZN10nsDocument27DispatchContentLoadedEventsEv
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:5058
  51:     0x7fffe4928d19 - _ZN7mozilla6detail23RunnableMethodArgumentsIJEE9applyImplI10nsDocumentMS4_FvvEJEJEEEDTcldsdefp_fp0_spcldtcl3GetIXT2_EEfp1_E15PassAsParameterEEEPT_T0_RNS_5TupleIJDpT1_EEENS_13IndexSequenceIJXspT2_EEEE
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:791
  52:     0x7fffe4928c98 - _ZN7mozilla6detail23RunnableMethodArgumentsIJEE5applyI10nsDocumentMS4_FvvEEEDTcl9applyImplfp_fp0_dtdefpT10mArgumentscvNS_13IndexSequenceIJEEE_EEEPT_T0_
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:797
  53:     0x7fffe4928b21 - _ZN7mozilla6detail18RunnableMethodImplIM10nsDocumentFvvELb1ELb0EJEE3RunEv
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:826
  54:     0x7fffe2ad0ca7 - _ZN8nsThread16ProcessNextEventEbPb
                        at /z/stylo/hg-incubator/xpcom/threads/nsThread.cpp:1213
  55:     0x7fffe2b505fb - _Z19NS_ProcessNextEventP9nsIThreadb
                        at /z/stylo/hg-incubator/xpcom/glue/nsThreadUtils.cpp:381
  56:     0x7fffe33cb0e8 - _ZN7mozilla3ipc11MessagePump3RunEPN4base11MessagePump8DelegateE
                        at /z/stylo/hg-incubator/ipc/glue/MessagePump.cpp:96
  57:     0x7fffe33296c4 - _ZN11MessageLoop11RunInternalEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:232
  58:     0x7fffe3329644 - _ZN11MessageLoop10RunHandlerEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:225
  59:     0x7fffe332961c - _ZN11MessageLoop3RunEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:205
  60:     0x7fffe6ad4002 - _ZN14nsBaseAppShell3RunEv
                        at /z/stylo/hg-incubator/widget/nsBaseAppShell.cpp:156
  61:     0x7fffe7cab191 - _ZN12nsAppStartup3RunEv
                        at /z/stylo/hg-incubator/toolkit/components/startup/nsAppStartup.cpp:283
  62:     0x7fffe7da48ab - _ZN7XREMain11XRE_mainRunEv
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4485
  63:     0x7fffe7da5395 - _ZN7XREMain8XRE_mainEiPPcPK12nsXREAppData
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4618
  64:     0x7fffe7da5b6e - XRE_main
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4709
  65:           0x40633e - _ZL7do_mainiPPcS0_P7nsIFile
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:328
  66:           0x405a61 - main
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:461
  67:     0x7ffff6d6c82f - __libc_start_main
  68:           0x4058f8 - _start
editor/libeditor/crashtests/766413.html
editor/libeditor/crashtests/768765.html
editor/libeditor/crashtests/793866.html
layout/base/crashtests/1140198.html
Summary: stylo: editor/libeditor/crashtests/766413.html panics with "Snapshots should be expanded by the caller" → stylo: several tests panic with "Snapshots should be expanded by the caller"
layout/generic/crashtests/898871.html intermittently hits this too.
Incremental restyle.
Flags: needinfo?(bobbyholley)
Retesting with the patches in bug 1325734, these now pass:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6764cd270b6fc4629cdf1168d641170720b6e531

I'll enable them along with bug 1325734.
Assignee: nobody → bobbyholley
Depends on: 1325734
Flags: needinfo?(bobbyholley)
https://hg.mozilla.org/mozilla-central/rev/4a0172713d6b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.