1323717 - stylo: layout/style/crashtests/1290994-4.html panics with "assertion failed: value >= 0. && value <= 1."

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

thread '<unnamed>' panicked at 'assertion failed: value >= 0. && value <= 1.', /z/stylo/hg-incubator/servo/components/style/keyframes.rs:42
stack backtrace:
   1:     0x7fffea9ba11f - std::sys::backtrace::tracing::imp::write::hd6ece0fd16ebfe06
   2:     0x7fffea9c967d - std::panicking::default_hook::{{closure}}::h523f1cb7f97bbc83
   3:     0x7fffea9c6bda - std::panicking::default_hook::hc3c81c24cdcc8c31
   4:     0x7fffea9c71d8 - std::panicking::rust_panic_with_hook::hf4b937f570e0ba05
   5:     0x7fffea121a13 - std::panicking::begin_panic::hcb26c0e753df7acf
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libstd/panicking.rs:413
   6:     0x7fffea3dcab9 - style::keyframes::KeyframePercentage::new::hae3a0333461204a0
                        at /z/stylo/hg-incubator/servo/components/style/keyframes.rs:42
   7:     0x7fffea3dcc30 - style::keyframes::KeyframePercentage::parse::hc7bc68a522ded72c
                        at /z/stylo/hg-incubator/servo/components/style/keyframes.rs:56
   8:     0x7fffea708833 - core::ops::FnMut::call_mut::h2e9fe60189cf2f82
   9:     0x7fffea6f8627 - cssparser::parser::Parser::parse_comma_separated::{{closure}}::hdb5db211b2220449
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:369
  10:     0x7fffea338f6a - cssparser::parser::Parser::parse_entirely::h5d17dba35d66405b
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:349
  11:     0x7fffea35e987 - cssparser::parser::Parser::parse_until_before::h4989ad7881afcff5
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:439
  12:     0x7fffea371647 - cssparser::parser::Parser::parse_comma_separated::hed43fda219248430
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:369
  13:     0x7fffea3dcd1b - style::keyframes::KeyframeSelector::parse::hb61e608a69a7bbf1
                        at /z/stylo/hg-incubator/servo/components/style/keyframes.rs:80
  14:     0x7fffea3dd8bb - <style::keyframes::KeyframeListParser<'a> as cssparser::rules_and_declarations::QualifiedRuleParser>::parse_prelude::ha1cae840b531d350
                        at /z/stylo/hg-incubator/servo/components/style/keyframes.rs:293
  15:     0x7fffea6f2066 - cssparser::rules_and_declarations::parse_qualified_rule::{{closure}}::h6a4aaf544df50352
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:429
  16:     0x7fffea335122 - cssparser::parser::Parser::parse_entirely::h3417c30fa324b045
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:349
  17:     0x7fffea35bb6e - cssparser::parser::Parser::parse_until_before::h19701f2680981e0a
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:439
  18:     0x7fffea327bf1 - cssparser::rules_and_declarations::parse_qualified_rule::h9b663c8abcf54ddd
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:428
  19:     0x7fffea08b222 - <cssparser::rules_and_declarations::RuleListParser<'i, 't, 'a, P> as core::iter::iterator::Iterator>::next::h54e360270bfc05a4
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:332
  20:     0x7fffea2d410e - <&'a mut I as core::iter::iterator::Iterator>::next::ha8480be0363270c1
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcore/iter/iterator.rs:2146
  21:     0x7fffea2ffd39 - <core::iter::FilterMap<I, F> as core::iter::iterator::Iterator>::next::h73bbee0396fd365f
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcore/iter/mod.rs:1019
  22:     0x7fffea30ecb6 - <collections::vec::Vec<T> as core::iter::traits::FromIterator<T>>::from_iter::h0571c9ccc5bceada
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcollections/vec.rs:1453
  23:     0x7fffea2242f9 - core::iter::iterator::Iterator::collect::h8482abde7af374c8
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcore/iter/iterator.rs:1200
  24:     0x7fffea3dd850 - style::keyframes::parse_keyframe_list::h4116c235e040de7d
                        at /z/stylo/hg-incubator/servo/components/style/keyframes.rs:276
  25:     0x7fffea3f4d21 - <style::stylesheets::NestedRuleParser<'a, 'b> as cssparser::rules_and_declarations::AtRuleParser>::parse_block::hfc1ed71816c7ebc4
                        at /z/stylo/hg-incubator/servo/components/style/stylesheets.rs:765
  26:     0x7fffea3f3eee - <style::stylesheets::TopLevelRuleParser<'a> as cssparser::rules_and_declarations::AtRuleParser>::parse_block::ha5cbe437adca1bc2
                        at /z/stylo/hg-incubator/servo/components/style/stylesheets.rs:664
  27:     0x7fffea6f16e2 - cssparser::rules_and_declarations::parse_at_rule::{{closure}}::h2430b25180b55724
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:396
  28:     0x7fffea33d749 - cssparser::parser::Parser::parse_entirely::h7fbeca40e355839d
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:349
  29:     0x7fffea359311 - cssparser::parser::Parser::parse_nested_block::he23c9967c0526f07
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/parser.rs:410
  30:     0x7fffea326730 - cssparser::rules_and_declarations::parse_at_rule::he0bc23bb96185f65
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:396
  31:     0x7fffea08b6af - <cssparser::rules_and_declarations::RuleListParser<'i, 't, 'a, P> as core::iter::iterator::Iterator>::next::h8ce53a650f26c3be
                        at /z/stylo/hg-incubator/third_party/rust/cssparser/src/rules_and_declarations.rs:326
  32:     0x7fffea3f2a93 - style::stylesheets::Stylesheet::from_str::h5bbdd8c8275a4574
                        at /z/stylo/hg-incubator/servo/components/style/stylesheets.rs:448
  33:     0x7fffe9ea96e0 - Servo_StyleSheet_FromUTF8Bytes
                        at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:265
  34:     0x7fffe6d18f4a - _ZN7mozilla15ServoStyleSheet10ParseSheetERK18nsAString_internalP6nsIURIS5_P12nsIPrincipalj
                        at /z/stylo/hg-incubator/layout/style/ServoStyleSheet.cpp:90
  35:     0x7fffe6d16d4a - _ZN7mozilla3css6Loader10ParseSheetERK18nsAString_internalPNS0_13SheetLoadDataERb
                        at /z/stylo/hg-incubator/layout/style/Loader.cpp:1778
  36:     0x7fffe6d1a24a - _ZN7mozilla3css6Loader15LoadInlineStyleEP10nsIContentRK18nsAString_internaljS6_S6_PNS_3dom7ElementEP20nsICSSLoaderObserverPbSC_
                        at /z/stylo/hg-incubator/layout/style/Loader.cpp:2045
  37:     0x7fffe499f9e1 - _ZN18nsStyleLinkElement18DoUpdateStyleSheetEP11nsIDocumentPN7mozilla3dom10ShadowRootEP20nsICSSLoaderObserverPbS8_b
                        at /z/stylo/hg-incubator/dom/base/nsStyleLinkElement.cpp:427
  38:     0x7fffe499ee62 - _ZN18nsStyleLinkElement16UpdateStyleSheetEP20nsICSSLoaderObserverPbS2_b
                        at /z/stylo/hg-incubator/dom/base/nsStyleLinkElement.cpp:222
  39:     0x7fffe3fd3f37 - _ZN22nsHtml5DocumentBuilder16UpdateStyleSheetEP10nsIContent
                        at /z/stylo/hg-incubator/parser/html/nsHtml5DocumentBuilder.cpp:76
  40:     0x7fffe403431b - _ZN20nsHtml5TreeOperation7PerformEP21nsHtml5TreeOpExecutorPP10nsIContent
                        at /z/stylo/hg-incubator/parser/html/nsHtml5TreeOperation.cpp:802
  41:     0x7fffe40157f5 - _ZN21nsHtml5TreeOpExecutor12RunFlushLoopEv
                        at /z/stylo/hg-incubator/parser/html/nsHtml5TreeOpExecutor.cpp:451
  42:     0x7fffe402d2f0 - _ZN22nsHtml5ExecutorFlusher3RunEv
                        at /z/stylo/hg-incubator/parser/html/nsHtml5StreamParser.cpp:128
  43:     0x7fffe2ad0ca7 - _ZN8nsThread16ProcessNextEventEbPb
                        at /z/stylo/hg-incubator/xpcom/threads/nsThread.cpp:1213
  44:     0x7fffe2b505fb - _Z19NS_ProcessNextEventP9nsIThreadb
                        at /z/stylo/hg-incubator/xpcom/glue/nsThreadUtils.cpp:381
  45:     0x7fffe33cb0e8 - _ZN7mozilla3ipc11MessagePump3RunEPN4base11MessagePump8DelegateE
                        at /z/stylo/hg-incubator/ipc/glue/MessagePump.cpp:96
  46:     0x7fffe33296c4 - _ZN11MessageLoop11RunInternalEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:232
  47:     0x7fffe3329644 - _ZN11MessageLoop10RunHandlerEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:225
  48:     0x7fffe332961c - _ZN11MessageLoop3RunEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:205
  49:     0x7fffe6ad4002 - _ZN14nsBaseAppShell3RunEv
                        at /z/stylo/hg-incubator/widget/nsBaseAppShell.cpp:156
  50:     0x7fffe7cab191 - _ZN12nsAppStartup3RunEv
                        at /z/stylo/hg-incubator/toolkit/components/startup/nsAppStartup.cpp:283
  51:     0x7fffe7da48ab - _ZN7XREMain11XRE_mainRunEv
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4485
  52:     0x7fffe7da5395 - _ZN7XREMain8XRE_mainEiPPcPK12nsXREAppData
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4618
  53:     0x7fffe7da5b6e - XRE_main
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4709
  54:           0x40633e - _ZL7do_mainiPPcS0_P7nsIFile
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:328
  55:           0x405a61 - main
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:461
  56:     0x7ffff6d6c82f - __libc_start_main
  57:           0x4058f8 - _start

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Fix about to land in https://github.com/servo/servo/pull/14605.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1323717 - Re-enable 1290994-4.html.

Review commit: https://reviewboard.mozilla.org/r/101688/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101688/

Comment 3

[Manish Goregaokar [:manishearth]]

Comment on attachment 8823065 [details]
Bug 1323717 - Re-enable 1290994-4.html.

https://reviewboard.mozilla.org/r/101688/#review102128

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/041ff7c0f3dd
Re-enable 1290994-4.html. r=manishearth

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/041ff7c0f3dd