Remove Windows XP and Vista theme code and resources

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Theme
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Depends on: 1 bug)

Trunk
Firefox 53
All
Windows XP
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
Big patch but straightforward. Let me know if you'd rather not review this, though.
(Assignee)

Updated

2 years ago
Assignee: nobody → dao+bmo
No problem, I'll do it.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8821609 [details]
Bug 1323810 - Remove Windows XP and Vista theme code and resources.

https://reviewboard.mozilla.org/r/100846/#review101538

::: browser/themes/windows/jar.mn:171
(Diff revision 1)
> +% override chrome://browser/skin/reload-stop-go.png                   chrome://browser/skin/reload-stop-go-win7.png                 os=WINNT osversion<=6.1
> +% override chrome://browser/skin/reload-stop-go@2x.png                chrome://browser/skin/reload-stop-go-win7@2x.png              os=WINNT osversion<=6.1
> +% override chrome://browser/skin/sync-horizontalbar.png               chrome://browser/skin/sync-horizontalbar-win7.png             os=WINNT osversion<=6.1
> +% override chrome://browser/skin/sync-horizontalbar@2x.png            chrome://browser/skin/sync-horizontalbar-win7@2x.png          os=WINNT osversion<=6.1
> +% override chrome://browser/skin/syncProgress-horizontalbar.png       chrome://browser/skin/syncProgress-horizontalbar-win7.png     os=WINNT osversion<=6.1
> +% override chrome://browser/skin/syncProgress-horizontalbar@2x.png    chrome://browser/skin/syncProgress-horizontalbar-win7@2x.png  os=WINNT osversion<=6.1
> +% override chrome://browser/skin/toolbarbutton-dropdown-arrow.png     chrome://browser/skin/toolbarbutton-dropdown-arrow-win7.png   os=WINNT osversion<=6.1
> +% override chrome://browser/skin/urlbar-history-dropmarker.png        chrome://browser/skin/urlbar-history-dropmarker-win7.png      os=WINNT osversion<=6.1
> +% override chrome://browser/skin/urlbar-history-dropmarker@2x.png     chrome://browser/skin/urlbar-history-dropmarker-win7@2x.png   os=WINNT osversion<=6.1
> +% override chrome://browser/skin/downloads/download-glow-menuPanel.png  chrome://browser/skin/downloads/download-glow-menuPanel-win7.png os=WINNT osversion<=6.1
> +% override chrome://browser/skin/tabbrowser/newtab.svg                chrome://browser/skin/tabbrowser/newtab-win7.svg              os=WINNT osversion<=6.1
> +% override chrome://browser/skin/tabbrowser/newtab-inverted.svg       chrome://browser/skin/tabbrowser/newtab-inverted-win7.svg     os=WINNT osversion<=6.1
> +% override chrome://browser/skin/tabbrowser/tab-arrow-left.svg        chrome://browser/skin/tabbrowser/tab-arrow-left-win7.svg      os=WINNT osversion<=6.1

This can be written now as:
os=WINNT osversion=6.1
because there is no lower version than Win7.

::: toolkit/themes/windows/global/jar.mn:61
(Diff revision 1)
> -% override chrome://global/skin/dirListing/folder.png             chrome://global/skin/dirListing/folder-XP.png            osversion<6
> -% override chrome://global/skin/dirListing/local.png              chrome://global/skin/dirListing/local-XP.png             osversion<6
> -% override chrome://global/skin/dirListing/remote.png             chrome://global/skin/dirListing/remote-XP.png            osversion<6
> -% override chrome://global/skin/dirListing/up.png                 chrome://global/skin/dirListing/up-XP.png                osversion<6
> +% override chrome://global/skin/icons/close.png                   chrome://global/skin/icons/close-win7.png            osversion<=6.1
> +% override chrome://global/skin/icons/close@2x.png                chrome://global/skin/icons/close-win7@2x.png         osversion<=6.1
> +% override chrome://global/skin/icons/close-inverted.png          chrome://global/skin/icons/close-inverted-win7.png   osversion<=6.1
> +% override chrome://global/skin/icons/close-inverted@2x.png       chrome://global/skin/icons/close-inverted-win7@2x.png osversion<=6.1

This can be written now as:
osversion=6.1
because there is no lower version than Win7.
Attachment #8821609 - Flags: review?(richard.marti) → review+
(Assignee)

Comment 5

2 years ago
(In reply to Richard Marti (:Paenglab) from comment #4)
> This can be written now as:
> os=WINNT osversion=6.1
> because there is no lower version than Win7.

True but rewriting osversion<=6.1 as osversion=6.1 doesn't provide benefits either. This is also consistent with how we used osversion<6 for XP images.

Comment 6

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e444885af53
Remove Windows XP and Vista theme code and resources. r=Paenglab
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1154657
(Assignee)

Updated

2 years ago
Blocks: 879609
(Assignee)

Updated

2 years ago
Blocks: 906871
(Assignee)

Updated

2 years ago
Blocks: 646604
(Assignee)

Updated

2 years ago
Blocks: 925156
(Assignee)

Updated

2 years ago
Blocks: 882623

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e444885af53
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
this has a measured win for the installer size:
== Change summary for alert #4652 (as of December 27 2016 05:01 UTC) ==

Improvements:

  0%  installer size summary windows2012-32 pgo     53431573.75 -> 53266910.5
  0%  installer size summary windows2012-64 pgo     57305915.5 -> 57152272.25
  0%  installer size summary windows2012-32 opt     52239132.33 -> 52104624.08
  0%  installer size summary windowsxp opt          52300211.75 -> 52165260.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4652
You need to log in before you can comment on or make changes to this bug.