906871 - White square appears around the new Firefox 23 icon in Windows XP using 16bit color mode.

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Cpuroast]

Attachment: Firefox23_16bit.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.57 Safari/537.36

Steps to reproduce:

Upgrade to Firefox 23.


Actual results:

New Firefox 23 icon is surrounded by an ugly white square.


Expected results:

No ugly white square surrounds the new Firefox 23 icon.

Comment 1

[Mardeg]

Noticed by Cpuroast connecting to XP via remote desktop since that maxes out at 16bit

Comment 2

[Stephen Horlander [:shorlander]]

I will look into this. There are few issues with the icon. I think it has something to do with the way it was generated.

Comment 4

[Bogdan Maris, Desktop QA]

I can reproduce this on Windows XP x32 updating from 22RC to 23.0.1RC

Comment 5

[Filipus Klutiero]

This appeared upgrading from Firefox 22 to Firefox 23 and persists with Firefox 24. It affects Windows Server 2003. Sometimes the icon displays fine. This bug report made me realize the variable is indeed 16-bit display, which we force for users to improve RDP performance.

Comment 7

[Chris McCray]

Hi, a workaround for my WinXP machine (that only has a 16-bit display) was to download the Windows icon file from here:

http://blog.mozilla.org/faaborg/2009/06/18/the-new-firefox-icon/

specifically this is the .ico file to get:

http://people.mozilla.com/~faaborg/files/shiretoko/firefoxIcon/firefox.ico

Then use that as the application icon and as the shortcut icon.  Reading the comments at the bottom of the web page some people have concerns about the contrast of the icon in certain applications.  Personally, it's just nice to have a transparent icon.

HTH. Chris.

Comment 8

[NetVicious]

Attachment: New ico file with fixed 256colors glyphs

Comment 9

[NetVicious]

Opening the ico file Chris McCray linked with a ICO editor I get this warning when opening 256 colors icons:

------------

WARNING!
The color palette does not include the color white.

Use of the 'inverse' color will be unpredictable until a true white entry (255,255,255) has been defined in the color palette.

------------

I fixed it in the previous attachment. Please test it.

Comment 10

[Cpuroast]

We are now on Firefox 33 and this issue with the icon in 16bit color mode on Windows XP has yet to be resolved. Surprised it's taking this long. The initial bug was first observed in Firefox 23. 10 versions later, ~60 weeks, it's still unresolved.

Comment 11

[NetVicious]

And with a fixed icon on attachment 8417453 [details] (2014-05-05 09:21:44 PDT).

Devs only need to replace old icon by the icon on that attachment. Fast and easy to do.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to NetVicious from comment #11)
> And with a fixed icon on attachment 8417453 [details] (2014-05-05 09:21:44
> PDT).
> 
> Devs only need to replace old icon by the icon on that attachment. Fast and
> easy to do.

The icon provided in comment 9 is now the old Firefox icon, which was redesigned a month later in late June, 2014.

Stephen, did you create one with a white color in the palette?

Comment 13

[Stephen Horlander [:shorlander]]

For some reason I thought we fixed this. Let me check my icon files, I have a fixed one.

Comment 14

[NetVicious]

Here the problem continues with white square.

I deleted the IconCache.db file of Windows to assure it.

Comment 17

[NetVicious]

Hi! I don't know why it's as difficult to fix this bug. On the crossed out (I don't know why) attachment 8417453 [details] I posted a fixed .ico on 2014-05-05.

Comment 18

[Dão Gottwald [:dao]]

We've dropped support for Windows XP.

Comment 19

[TA]

(In reply to Dão Gottwald [:dao] from comment #18)
> We've dropped support for Windows XP.

I think it is problem of FF icon on Remote Desktop Connection or always in 16bpp mode, not only for XP.