Closed Bug 1323912 Opened 3 years ago Closed 3 years ago

Paint opacity into non SVG mask

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: u459114, Assigned: u459114)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

See the comment:
https://hg.mozilla.org/mozilla-central/file/2d28fe1daf68/layout/svg/nsSVGIntegrationUtils.cpp#l583

Currently, we are able to apply opacity into svg mask only. Create this bug to enable applying opacity into image/gradient mask.
Attachment #8823197 - Flags: review?(mstange)
Attachment #8823198 - Flags: review?(mstange)
Attachment #8823531 - Flags: review?(mstange)
Attachment #8823532 - Flags: review?(mstange)
Attachment #8823533 - Flags: review?(mstange)
Attachment #8823534 - Flags: review?(mstange)
Comment on attachment 8823197 [details]
Bug 1323912 - Part 1. Rename PaintBackground to PaintStyleImageLayer.

https://reviewboard.mozilla.org/r/101782/#review102448
Attachment #8823197 - Flags: review?(mstange) → review+
Comment on attachment 8823198 [details]
Bug 1323912 - Part 2. Pass opacity down to imgIContainer::Draw.

https://reviewboard.mozilla.org/r/101784/#review102450
Attachment #8823198 - Flags: review?(mstange) → review+
Comment on attachment 8823531 [details]
Bug 1323912 - Part 3. Pass opacity in gradient-mask painting path.

https://reviewboard.mozilla.org/r/102052/#review102452
Attachment #8823531 - Flags: review?(mstange) → review+
Comment on attachment 8823532 [details]
Bug 1323912 - Part 4. Apply opacity in indirect image mask painting path.

https://reviewboard.mozilla.org/r/102054/#review102454
Attachment #8823532 - Flags: review?(mstange) → review+
Comment on attachment 8823533 [details]
Bug 1323912 - Part 5. Apply opacity in mask layer painting path.

https://reviewboard.mozilla.org/r/102056/#review102456
Attachment #8823533 - Flags: review?(mstange) → review+
Comment on attachment 8823534 [details]
Bug 1323912 - Part 6. Test cases.

https://reviewboard.mozilla.org/r/102058/#review102458
Attachment #8823534 - Flags: review?(mstange) → review+
The mask-opacity-1d failure affects 53 so these patches have to land in 53 because mask-image is riding the trains with 53, correct?
(In reply to Markus Stange [:mstange] from comment #16)
> The mask-opacity-1d failure affects 53 so these patches have to land in 53
> because mask-image is riding the trains with 53, correct?

Correct.
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a44640701558
Part 1. Rename PaintBackground to PaintStyleImageLayer. r=mstange
https://hg.mozilla.org/integration/autoland/rev/c868ab532766
Part 2. Pass opacity down to imgIContainer::Draw. r=mstange
https://hg.mozilla.org/integration/autoland/rev/71c136b30a4d
Part 3. Pass opacity in gradient-mask painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/a2f133998adf
Part 4. Apply opacity in indirect image mask painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b3ad53915c5e
Part 5. Apply opacity in mask layer painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/5de8385ec973
Part 6. Test cases. r=mstange
Sorry had to backout this for OS X 10.7 bustages, i.e., https://treeherder.mozilla.org/logviewer.html#?job_id=66285785&repo=autoland&lineNumber=1381
Flags: needinfo?(cku)
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/238522aa277e
Part 1. Rename PaintBackground to PaintStyleImageLayer. r=mstange
https://hg.mozilla.org/integration/autoland/rev/04689bf3a1f2
Part 2. Pass opacity down to imgIContainer::Draw. r=mstange
https://hg.mozilla.org/integration/autoland/rev/e83758b801cf
Part 3. Pass opacity in gradient-mask painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/dc22594f0214
Part 4. Apply opacity in indirect image mask painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/39ca4e6d2eb2
Part 5. Apply opacity in mask layer painting path. r=mstange
https://hg.mozilla.org/integration/autoland/rev/4fd4d2b90556
Part 6. Test cases. r=mstange
(In reply to Iris Hsiao [:ihsiao] from comment #19)
> Sorry had to backout this for OS X 10.7 bustages, i.e.,
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=66285785&repo=autoland&lineNumber=1381
Fixed
Flags: needinfo?(cku)
Depends on: 1329411
Depends on: 1329751
Depends on: 1346618
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.