1324006 - Event dialog: until date "forever" changes to today date when reopening the dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

Steps to reproduce:

- create a new event and select any repeating rule (e.g. weekly);
- don't change the default until date "forever", save and close the dialog;
- reopen the event just created.

--> the until date is now set to the today date instead of "forever".

When closing without changing nothing, the save prompt appears.


Regression range:
  build 2016 08 25 works
  build 2016 08 26 fails

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=b05a1a42ab8248314f9c2c93ca039f0a1e4cba34

Probably caused by bug 1294534

Comment 1

[Paul Morris [:pmorris]]

Thanks for reporting.  I'll take a look when I get a chance.

Comment 2

[Decathlon]

Attachment: patch-v1

This patch should fix.
Actually only the changes in file lightning-item-iframe.js fixes, but I think it's also needed in react-code.js

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 8819616 [details] [diff] [review]
patch-v1

Review of attachment 8819616 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 4

[Decathlon]

Pushed to comm-central
https://hg.mozilla.org/comm-central/rev/c4d7763403e9

Comment 5

[Decathlon]

Comment on attachment 8819616 [details] [diff] [review]
patch-v1

This is also needed in aurora and beta

Comment 6

[Decathlon]

Correct link for comm-central:
https://hg.mozilla.org/comm-central/rev/97a86c21e6c3

Pushed to comm-aurora
https://hg.mozilla.org/releases/comm-aurora/rev/8cef44d23bc3

Comment 7

[Decathlon]

Pushed to comm-beta:
https://hg.mozilla.org/releases/comm-beta/rev/e1cda4717bd8