1324118 - RTL support for devtool framework connection screen

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Tomer Cohen :tomer]

Steps to reproduce:

a. Launch an RTL Firefox build
b. Hamburger menu → Developer → Connect… (may appear different due to the browser locale. In Hebrew it is "התחברות…", the item above "View Source Ctrl-U")
c. A new browser tab will open with the chrome://devtools/content/framework/connect/connect.xhtml# page. 

Current result:
Page is localized but doesn't feature direction hints. We need to add dir=&locale.dir; to the page html or body elements.

Comment 1

[Tomer Cohen :tomer]

Attachment: [Bug 1324118] RTL support for devtool framework connection screen

Review commit: https://reviewboard.mozilla.org/r/99214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99214/

Comment 2

[Tomer Cohen :tomer]

Comment on attachment 8819446 [details]
[Bug 1324118] RTL support for devtool framework connection screen

https://reviewboard.mozilla.org/r/99214/#review99518

::: devtools/client/framework/connect/connect.css:40
(Diff revision 1)
>    text-align: right;
>    margin-right: 10px;

These properties needs to be replaced with start/end equivalents.

::: devtools/client/framework/connect/connect.css:48
(Diff revision 1)
> +input {
> +  unicode-bidi: plaintext;

This addition will make sure that input fields will be aligned well according to the context. On a second thought, I think I'll hardcode it to LTR, because numerical addresses such as 127.0.0.1 and ::1 doesn't contains a strong bidirectional characters, so the direction will be undetermined.

Comment 3

[Tomer Cohen :tomer]

Attachment: Before state (reference)

Comment 4

[Tomer Cohen :tomer]

Attachment: patch v1

Comment 5

[Tomer Cohen :tomer]

Comment on attachment 8819446 [details]
[Bug 1324118] RTL support for devtool framework connection screen

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99214/diff/1-2/

Comment 6

[Tomer Cohen :tomer]

Attachment: patch v2

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8819446 [details]
[Bug 1324118] RTL support for devtool framework connection screen

https://reviewboard.mozilla.org/r/99214/#review99550

Sounds good to me, thanks for the fix!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b72137e0459
[Bug 1324118] RTL support for devtool framework connection screen r=jryans

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/4b72137e0459

Comment 10

[Itiel]

Seems to be working fine in latest Nightly.

Comment 11

[Forhad Hossain]

I have reproduced the bug in Nightly 53.0a1 (2016-12-16) with the instruction from comment 0 and Linux 64 Bit

Bug is fixed now on Latest Beta 53.0b7 (Build ID:20170327151342)
User Agent:Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

 [bugday-20170329]