1324247 - Strip whitespace from queries in URL setters

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Manish Goregaokar [:manishearth]]

We currently don't strip whitespace when setting the query in URLs

> u = new URL("http://foo.bar?query")
> u.search = "qu\r\n\tery";
> console.log(u.href);
> // "http://foo.bar/?qu%0D%0A%09ery"

https://url.spec.whatwg.org/#dom-url-search

https://url.spec.whatwg.org/#concept-basic-url-parser step 3

Test at https://github.com/w3c/web-platform-tests/blob/be5820ecd36650bff4728208629553931fd42ec2/url/setters_tests.json#L1053

Discussion at https://github.com/whatwg/url/issues/172

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 3

[Valentin Gosu [:valentin]]

Attachment: Bug 1324247 - Strip whitespace from queries in URL setters r=#necko

Comment 4

[Valentin Gosu [:valentin]]

Attachment: Bug 1324247 - Strip whitespace from hash in URL setters r=#necko

Depends on D93471

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c9eda3b46f
Strip whitespace from queries in URL setters r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/333d32890af3
Strip whitespace from hash in URL setters r=necko-reviewers,dragana

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/13c9eda3b46f
https://hg.mozilla.org/mozilla-central/rev/333d32890af3