Closed Bug 1324338 Opened 8 years ago Closed 8 years ago

Remove static link to GLES lib on android

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

patch - Remove static link to GLES lib on android
649 bytes, patch
snorp
: review+
nical
: feedback+
Details | Diff | Splinter Review
It seems not necessary to link to GLES lib statically on android.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1324326
Attachment #8819737 - Flags: review?(nical.bugzilla)
Comment on attachment 8819737 [details] [diff] [review] patch - Remove static link to GLES lib on android Review of attachment 8819737 [details] [diff] [review]: ----------------------------------------------------------------- I don't know enough about this to give you a proper review but sounds good to me.
Attachment #8819737 - Flags: feedback+
Attachment #8819737 - Flags: review?(nical.bugzilla)
Attachment #8819737 - Flags: review?(snorp)
Comment on attachment 8819737 [details] [diff] [review] patch - Remove static link to GLES lib on android Review of attachment 8819737 [details] [diff] [review]: ----------------------------------------------------------------- Don't we dlopen all the GL stuff anyway? Why would we have ever wanted this?
Attachment #8819737 - Flags: review?(snorp) → review+
Wow, this goes all the way back to bug 564327, which introduced the Android widget.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #4) > Comment on attachment 8819737 [details] [diff] [review] > patch - Remove static link to GLES lib on android > > Review of attachment 8819737 [details] [diff] [review]: > ----------------------------------------------------------------- > > Don't we dlopen all the GL stuff anyway? Why would we have ever wanted this? Yea, we do dlopen all the GL stuff and we do not need the static link.
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aab443a1923f Remove static link to GLES lib on android r=snorp
https://hg.mozilla.org/mozilla-central/rev/aab443a1923f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: