about:config warning icon should be at the right side on RTL

VERIFIED FIXED in Firefox 53

Status

()

Firefox
Preferences
VERIFIED FIXED
4 months ago
a month ago

People

(Reporter: tomer, Assigned: tomer)

Tracking

53 Branch
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 verified)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
The warning icon on the about:config page appears at the left side of the title instead of the right side. This may be a regression, as the code has the fix for this issue on info-pages.css

.title:dir(rtl) {
  background-position: right 0;
}

I've found that this issue can be solved by using -moz-locale-dir(). I'll commit a patch shortly.
Comment hidden (mozreview-request)
Assignee: nobody → tomer.moz.bugs
Comment on attachment 8819763 [details]
Bug 1324356 about:config warning icon should be at the right side on RTL

https://reviewboard.mozilla.org/r/99406/#review99872

Not sure if you knew, but this is because :-moz-locale-dir() is used on XUL pages and :dir() is used on non-XUL pages. Thanks for the fix!
Attachment #8819763 - Flags: review?(jaws) → review+

Comment 3

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c24c401b9aa
about:config warning icon should be at the right side on RTL r=jaws
(Assignee)

Comment 4

4 months ago
mozreview-review-reply
Comment on attachment 8819763 [details]
Bug 1324356 about:config warning icon should be at the right side on RTL

https://reviewboard.mozilla.org/r/99406/#review99872

Yes, I know. I just don't want to be rude saying that someone was mistaken. ;-) 

Thanks for the review!
Great! I'm never offended by someone fixing a mistake :)

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2c24c401b9aa
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Comment 7

4 months ago
This fix caused a regression in other screens, as noted in bug 1325883. We need to backout this patch or apply to fix in bug 1325883.
QA Whiteboard: [good first verify]

Comment 8

a month ago
I have reproduced this bug in Nightly RTL(Hebrew) 53.0a1 (2016-12-19)

The bug is verified as fixed in latest Firefox beta 53.0b8 RTL(Hebrew) 

Build id: 20170330190824
User agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

[testday-20170331]
Thanks!
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.