1324356 - about:config warning icon should be at the right side on RTL

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Tomer Cohen :tomer]

The warning icon on the about:config page appears at the left side of the title instead of the right side. This may be a regression, as the code has the fix for this issue on info-pages.css

.title:dir(rtl) {
  background-position: right 0;
}

I've found that this issue can be solved by using -moz-locale-dir(). I'll commit a patch shortly.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1324356 about:config warning icon should be at the right side on RTL

Review commit: https://reviewboard.mozilla.org/r/99406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99406/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8819763 [details]
Bug 1324356 about:config warning icon should be at the right side on RTL

https://reviewboard.mozilla.org/r/99406/#review99872

Not sure if you knew, but this is because :-moz-locale-dir() is used on XUL pages and :dir() is used on non-XUL pages. Thanks for the fix!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c24c401b9aa
about:config warning icon should be at the right side on RTL r=jaws

Comment 4

[Tomer Cohen :tomer]

Comment on attachment 8819763 [details]
Bug 1324356 about:config warning icon should be at the right side on RTL

https://reviewboard.mozilla.org/r/99406/#review99872

Yes, I know. I just don't want to be rude saying that someone was mistaken. ;-) 

Thanks for the review!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Great! I'm never offended by someone fixing a mistake :)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2c24c401b9aa

Comment 7

[Tomer Cohen :tomer]

This fix caused a regression in other screens, as noted in bug 1325883. We need to backout this patch or apply to fix in bug 1325883.

Comment 8

[Sayed [:LiquidO2]]

I have reproduced this bug in Nightly RTL(Hebrew) 53.0a1 (2016-12-19)

The bug is verified as fixed in latest Firefox beta 53.0b8 RTL(Hebrew) 

Build id: 20170330190824
User agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

[testday-20170331]

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!