1324380 - Make setting Event's cancelBubble to false a no-op

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Anne (:annevk)]

Per https://dom.spec.whatwg.org/#dom-event-cancelbubble setting cancelBubble to false should do nothing.

WPT: https://github.com/w3c/web-platform-tests/pull/4304.

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Make setting Event's cancelBubble to false a no-op

Verified with following test cases and passed. Should I merge these tests to testing/web-platform/tests/dom/events/* as well?

http://w3c-test.org/dom/events/Event-initEvent.html
http://w3c-test.org/dom/events/Event-dispatch-multiple-cancelBubble.html
http://w3c-test.org/dom/events/Event-propagation.html
http://w3c-test.org/dom/events/Event-cancelBubble.html
http://w3c-test.org/dom/events/Event-dispatch-bubble-canceled.html

Comment 2

[Anne (:annevk)]

Those tests should end up being automatically synchronized at some point (still done manually I believe) so I don't think that's needed.

Comment 3

[Ming-Chou Shih [:stone]]

(In reply to Anne (:annevk) from comment #2)
> Those tests should end up being automatically synchronized at some point
> (still done manually I believe) so I don't think that's needed.
Thanks for the information.

Comment 4

[Ming-Chou Shih [:stone]]

Attachment: Make setting Event's cancelBubble to false a no-op. r=smaug.

Updated the patch summary.

Comment 5

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f00511a217d1ea2bd21b84f5baa6e24b46b04081

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52c2c53e8340
Make setting Event's cancelBubble to false a no-op. r=smaug.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52c2c53e8340

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8820475 [details] [diff] [review]
Make setting Event's cancelBubble to false a no-op. r=smaug.

Approval Request Comment
See https://bugzilla.mozilla.org/show_bug.cgi?id=1298970#c13

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8820475 [details] [diff] [review]
Make setting Event's cancelBubble to false a no-op. r=smaug.

follow spec for Event.cancelBubble, beta52+

Comment 10

[Carsten Book [:Tomcat]]

need rebasing for beta

grafting 380671:52c2c53e8340 "Bug 1324380 - Make setting Event's cancelBubble to false a no-op. r=smaug."
merging dom/events/Event.cpp
warning: conflicts while merging dom/events/Event.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df9973164d86