Move cancelBubble to Event

RESOLVED FIXED in Firefox 52

Status

()

defect
P2
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Nika, Assigned: stone)

Tracking

({dev-doc-complete})

unspecified
mozilla53
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52- fixed, firefox53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is causing problems with selectevents enabled in OWA. See bug 1280534.
Spec bug?
Priority: -- → P2
Assignee: nobody → bugs
stone, want to take this ? :)
Flags: needinfo?(sshih)
though, the spec issue is still open.
But I think we could still implement this.
Assignee

Updated

3 years ago
Assignee: bugs → sshih
Flags: needinfo?(sshih)
Assignee

Comment 6

3 years ago
Attachment #8815657 - Flags: review?(bugs)
Comment on attachment 8815657 [details] [diff] [review]
Move UIEvent.cancelBubble to Event

Thanks.
Attachment #8815657 - Flags: review?(bugs) → review+
Assignee

Comment 9

3 years ago
Updated the patch summary.
Attachment #8815657 - Attachment is obsolete: true
Attachment #8815959 - Flags: review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 10

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/033d5532cac7
Move UIEvent.cancelBubble to Event. r=smaug
Keywords: checkin-needed

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/033d5532cac7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 12

2 years ago
[Tracking Requested - why for this release]:

This problem also happens with OWA using Firefox 52.0b1

Could this fix please be added to the 52 branch - as 52 will be the next ESR release
Comment on attachment 8815959 [details] [diff] [review]
Bug 1298970 - Move UIEvent.cancelBubble to Event.

Approval Request Comment
[Feature/Bug causing the regression]: NA, but a spec change https://github.com/whatwg/dom/issues/211

[User impact if declined]: Broken pages
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]:
I'd uplift also https://bugzilla.mozilla.org/show_bug.cgi?id=1324380
[Is the change risky?]: No
[Why is the change risky/not risky?]: The property has been in browser for ages but implemented differently. It got recently spec'ed, and this patch makes us follow the spec.
[String changes made/needed]: NA
Attachment #8815959 - Flags: approval-mozilla-beta?
Comment on attachment 8815959 [details] [diff] [review]
Bug 1298970 - Move UIEvent.cancelBubble to Event.

follow spec change for cancelBubble attribute, beta52+
Attachment #8815959 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
needs rebasing for beta

grafting 378285:033d5532cac7 "Bug 1298970 - Move UIEvent.cancelBubble to Event. r=smaug"
merging dom/events/Event.cpp
merging dom/events/Event.h
merging dom/events/test/mochitest.ini
merging dom/webidl/Event.webidl
warning: conflicts while merging dom/events/test/mochitest.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
Flags: needinfo?(sshih)
Flags: needinfo?(sshih)
I've updated the affected docs pages:

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/Event#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble

I've also added a note to the Fx53 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

Let me know if these changes look OK, or if anything else needs to be done (Yes, I know the Event page looks scrappy and needs cleaning up; that is a job for another day.)

Comment 18

2 years ago
:cmills The spec table in https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble incorrectly refers to the Event interface generally instead of the Event.cancelBubble property specifically.
(In reply to Chris Rebert from comment #18)
> :cmills The spec table in
> https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble
> incorrectly refers to the Event interface generally instead of the
> Event.cancelBubble property specifically.

Ooops; fixed now. Thanks for spotting!

Comment 20

2 years ago
:cmills this change was pushed to Fx52 & ESR, I think it is worth updating Fx52 release note as well.
(In reply to assafdd from comment #20)
> :cmills this change was pushed to Fx52 & ESR, I think it is worth updating
> Fx52 release note as well.

Thanks for the heads up - I've updated the docs to say this happened from 52 onwards, not 53.
You need to log in before you can comment on or make changes to this bug.