1298970 - Move cancelBubble to Event

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This is causing problems with selectevents enabled in OWA. See bug 1280534.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Spec bug?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is being discussed in https://github.com/whatwg/dom/issues/211

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

stone, want to take this ? :)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

though, the spec issue is still open.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

But I think we could still implement this.

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: Move UIEvent.cancelBubble to Event

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8815657 [details] [diff] [review]
Move UIEvent.cancelBubble to Event

Thanks.

Comment 8

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10962face3c4adbe499fe14a87b86b61d9436d82

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Bug 1298970 - Move UIEvent.cancelBubble to Event.

Updated the patch summary.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/033d5532cac7
Move UIEvent.cancelBubble to Event. r=smaug

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/033d5532cac7

Comment 12

[James Pearson]

[Tracking Requested - why for this release]:

This problem also happens with OWA using Firefox 52.0b1

Could this fix please be added to the 52 branch - as 52 will be the next ESR release

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8815959 [details] [diff] [review]
Bug 1298970 - Move UIEvent.cancelBubble to Event.

Approval Request Comment
[Feature/Bug causing the regression]: NA, but a spec change https://github.com/whatwg/dom/issues/211

[User impact if declined]: Broken pages
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]:
I'd uplift also https://bugzilla.mozilla.org/show_bug.cgi?id=1324380
[Is the change risky?]: No
[Why is the change risky/not risky?]: The property has been in browser for ages but implemented differently. It got recently spec'ed, and this patch makes us follow the spec.
[String changes made/needed]: NA

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8815959 [details] [diff] [review]
Bug 1298970 - Move UIEvent.cancelBubble to Event.

follow spec change for cancelBubble attribute, beta52+

Comment 15

[Carsten Book [:Tomcat]]

needs rebasing for beta

grafting 378285:033d5532cac7 "Bug 1298970 - Move UIEvent.cancelBubble to Event. r=smaug"
merging dom/events/Event.cpp
merging dom/events/Event.h
merging dom/events/test/mochitest.ini
merging dom/webidl/Event.webidl
warning: conflicts while merging dom/events/test/mochitest.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b130f8af6d55

Comment 17

[Chris Mills [:cmills]]

I've updated the affected docs pages:

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/Event#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble

I've also added a note to the Fx53 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

Let me know if these changes look OK, or if anything else needs to be done (Yes, I know the Event page looks scrappy and needs cleaning up; that is a job for another day.)

Comment 18

[Chris Rebert]

:cmills The spec table in https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble incorrectly refers to the Event interface generally instead of the Event.cancelBubble property specifically.

Comment 19

[Chris Mills [:cmills]]

(In reply to Chris Rebert from comment #18)
> :cmills The spec table in
> https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelBubble
> incorrectly refers to the Event interface generally instead of the
> Event.cancelBubble property specifically.

Ooops; fixed now. Thanks for spotting!

Comment 20

[assafdd]

:cmills this change was pushed to Fx52 & ESR, I think it is worth updating Fx52 release note as well.

Comment 21

[Chris Mills [:cmills]]

(In reply to assafdd from comment #20)
> :cmills this change was pushed to Fx52 & ESR, I think it is worth updating
> Fx52 release note as well.

Thanks for the heads up - I've updated the docs to say this happened from 52 onwards, not 53.