“Item modified on server” message has layout issues

RESOLVED FIXED in 6.1

Status

Calendar
Lightning Only
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: gagne.patrick, Assigned: MakeMyDay)

Tracking

(Blocks: 1 bug)

unspecified

Details

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Created attachment 8819912 [details]
image.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce:

In lightning (in french), when I have to modify an event which was also modified in our server (sogo). Or when we have a reminder with an event with some text in the "description".


Actual results:

some text are too wide for the layout. Because a picture is worth a thousand words. See the attachments


Expected results:

For the text in the button, it will be correct to have shorter text OR an wider button.

For the text in description, trunk the content or a scroll bar?
Thanks for the report, moving the bug in the Calendar component as this will likely require code changes.

Here’s the message in the screenshot: https://hg.mozilla.org/comm-central/file/default/calendar/locales/en-US/chrome/calendar/calendar.properties#l266
Assignee: bugzilla.fr → nobody
Status: UNCONFIRMED → NEW
Component: fr / French → Lightning Only
Ever confirmed: true
Product: Mozilla Localizations → Calendar
QA Contact: benoit.leseul
Summary: in lightning, text are too wide for the text layout → “Item modified on server” message has layout issues
(Assignee)

Comment 2

a year ago
Can you please tell us about your setup (OS, theme, installed extensions, download source of TB/Lightning)? The screenshot doesn't look like a stock version of Lightning.
Flags: needinfo?(gagne.patrick)
(Reporter)

Comment 3

a year ago
Created attachment 8834543 [details]
TB version and extensions
(Reporter)

Comment 4

a year ago
(In reply to gagne.patrick from comment #3)
> Created attachment 8834543 [details]
> TB version and extensions

I tested this with Win 7 and 10 with default theme
(Assignee)

Comment 5

2 months ago
Created attachment 8939241 [details] [diff] [review]
MakeLongItemDescriptionsScrollableInConflictDialog-V1.diff

This patch makes the item description scrollable in the conflict dialog. I also added/updated doc blocks to mouseoverPreview.js where missing or incomplete. The linter is satisfied with that changes.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8939241 - Flags: review?(philipp)
(Assignee)

Updated

2 months ago
Flags: needinfo?(gagne.patrick)
(Assignee)

Updated

2 months ago
Blocks: 1414612
Attachment #8939241 - Flags: review?(philipp) → review+
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 6

2 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/34c27412bf32
Make long item descriptions in conflict dialog scrolling to not overflow the dialog controls. r=philipp
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

2 months ago
Target Milestone: --- → 6.1
You need to log in before you can comment on or make changes to this bug.