In VideoPlayer.java there is a deprecated LayoutParams `FILL_PARENT`, now we can switch to proper parameters.
This is a easy bug and good for any newcomer who is interesting in Fennec development. Feel free to pick up this one. https://dxr.mozilla.org/mozilla-central/rev/d4b3146a5567a7ddbcdfa5244945db55616cb8d1/mobile/android/base/java/org/mozilla/gecko/media/VideoPlayer.java#194 If you have no idea what to do, you can refer to [bug 1027831]
Whiteboard: [good first bug] → [good first bug][lang=java]
If you are new then to start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build Fix the issue mentioned in comment 0 (FILL_PARENT -> MATCH_PARENT) and then you'll need to upload a patch - see: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html If you need any help, you can reply to this bug, or feel free to ask for help on IRC in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Can you assign me to this? I've built the environment already.
Thanks George. Sebastian given detailed guide what you can follow. You can also use 'Need more information from..' field to highlight anyone to reply you on bugzilla.
Assignee: nobody → f2013112
Changed VideoPlayer.java Replaced FILL_PARENT with MATCH_PARENT on line 194 Fixes bug 1324656
Attachment #8820531 - Flags: review?(walkingice0204)
Attachment #8820531 - Flags: review?(walkingice0204) → review+
I pushed this change to try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=250e0ba24e506e97fcc5c8a5c9e56bc4e7ee23c0
What should I do now?
I think everything is good but waiting for landing patch. Maybe next patch you can try MozReview to send patch for reviewing. (Uploading patch as attachment is still good way). Then you can understand more about development process. Thanks!
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb20776dff9 Replaced FILL_PARENT with MATCH_PARENT in VideoPlayer.java. r=walkingice0204.
Any other bug I can work on in the meantime?
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
@walkingice @sebastian Is it done? If so what should I work on now?
Hi George, your patch is already merged (thanks). You can find out another Good First Bug if you want more practice for development process. Or you can find any interested bugs to fix. This is bugs list for what be tagged 'tracking-fennec' https://bugzilla.mozilla.org/buglist.cgi?priority=--&f1=cf_blocking_fennec&list_id=13367862&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cresolution%2Ctarget_milestone%2Cshort_desc%2Cstatus_whiteboard%2Ckeywords%2Ccf_blocking_b2g%2Ccf_feature_b2g%2Cchangeddate%2Cpriority&o1=equals&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&v1=%2B&product=Firefox%20for%20Android
You need to log in before you can comment on or make changes to this bug.