Change deprecated LayoutParams FILL_PARENT in VideoPlayer.java

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
--
trivial
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: walkingice, Assigned: George, Mentored)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(fennec+, firefox53 fixed)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
In VideoPlayer.java there is a deprecated LayoutParams `FILL_PARENT`, now we can switch to proper parameters.
(Reporter)

Updated

8 months ago
tracking-fennec: --- → +
(Reporter)

Comment 1

8 months ago
This is a easy bug and good for any newcomer who is interesting in Fennec development. Feel free to pick up this one.

https://dxr.mozilla.org/mozilla-central/rev/d4b3146a5567a7ddbcdfa5244945db55616cb8d1/mobile/android/base/java/org/mozilla/gecko/media/VideoPlayer.java#194

If you have no idea what to do, you can refer to [bug 1027831]
Mentor: walkingice0204@gmail.com
Whiteboard: [good first bug] → [good first bug][lang=java]
If you are new then to start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Fix the issue mentioned in comment 0 (FILL_PARENT -> MATCH_PARENT) and then you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to ask for help on IRC in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
(Assignee)

Comment 3

8 months ago
Can you assign me to this? I've built the environment already.
(Reporter)

Comment 4

8 months ago
Thanks George. Sebastian given detailed guide what you can follow. You can also use 'Need more information from..' field to highlight anyone to reply you on bugzilla.
Assignee: nobody → f2013112
(Assignee)

Comment 5

8 months ago
Created attachment 8820531 [details] [diff] [review]
tip.patch

Changed VideoPlayer.java
Replaced FILL_PARENT with MATCH_PARENT on line 194
Fixes bug 1324656
Attachment #8820531 - Flags: review?(walkingice0204)
(Reporter)

Updated

8 months ago
Attachment #8820531 - Flags: review?(walkingice0204) → review+
(Reporter)

Comment 6

8 months ago
I pushed this change to try server
https://treeherder.mozilla.org/#/jobs?repo=try&revision=250e0ba24e506e97fcc5c8a5c9e56bc4e7ee23c0
(Reporter)

Updated

8 months ago
Keywords: checkin-needed
(Assignee)

Comment 7

8 months ago
What should I do now?
(Reporter)

Comment 8

8 months ago
I think everything is good but waiting for landing patch.

Maybe next patch you can try MozReview to send patch for reviewing. (Uploading patch as attachment is still good way). Then you can understand more about development process.

Thanks!

Comment 9

8 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb20776dff9
Replaced FILL_PARENT with MATCH_PARENT in VideoPlayer.java. r=walkingice0204.
Keywords: checkin-needed
(Assignee)

Comment 10

8 months ago
Any other bug I can work on in the meantime?

Comment 11

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cbb20776dff9
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Comment 12

8 months ago
@walkingice @sebastian Is it done? If so what should I work on now?
(Reporter)

Comment 13

8 months ago
Hi George, your patch is already merged (thanks). You can find out another Good First Bug if you want more practice for development process. Or you can find any interested bugs to fix.

This is bugs list for what be tagged 'tracking-fennec'

https://bugzilla.mozilla.org/buglist.cgi?priority=--&f1=cf_blocking_fennec&list_id=13367862&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cresolution%2Ctarget_milestone%2Cshort_desc%2Cstatus_whiteboard%2Ckeywords%2Ccf_blocking_b2g%2Ccf_feature_b2g%2Cchangeddate%2Cpriority&o1=equals&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&v1=%2B&product=Firefox%20for%20Android
You need to log in before you can comment on or make changes to this bug.