Change deprecated LayoutParams FILL_PARENT in VideoPlayer.java

RESOLVED FIXED in Firefox 53

Status

()

--
trivial
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: walkingice, Assigned: f2013112, Mentored)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(fennec+, firefox53 fixed)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
In VideoPlayer.java there is a deprecated LayoutParams `FILL_PARENT`, now we can switch to proper parameters.
(Reporter)

Updated

2 years ago
tracking-fennec: --- → +
(Reporter)

Comment 1

2 years ago
This is a easy bug and good for any newcomer who is interesting in Fennec development. Feel free to pick up this one.

https://dxr.mozilla.org/mozilla-central/rev/d4b3146a5567a7ddbcdfa5244945db55616cb8d1/mobile/android/base/java/org/mozilla/gecko/media/VideoPlayer.java#194

If you have no idea what to do, you can refer to [bug 1027831]
Mentor: walkingice0204
Whiteboard: [good first bug] → [good first bug][lang=java]
If you are new then to start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Fix the issue mentioned in comment 0 (FILL_PARENT -> MATCH_PARENT) and then you'll need to upload a patch - see:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

If you need any help, you can reply to this bug, or feel free to ask for help on IRC in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
(Assignee)

Comment 3

2 years ago
Can you assign me to this? I've built the environment already.
(Reporter)

Comment 4

2 years ago
Thanks George. Sebastian given detailed guide what you can follow. You can also use 'Need more information from..' field to highlight anyone to reply you on bugzilla.
Assignee: nobody → f2013112
(Assignee)

Comment 5

2 years ago
Posted patch tip.patchSplinter Review
Changed VideoPlayer.java
Replaced FILL_PARENT with MATCH_PARENT on line 194
Fixes bug 1324656
Attachment #8820531 - Flags: review?(walkingice0204)
(Reporter)

Updated

2 years ago
Attachment #8820531 - Flags: review?(walkingice0204) → review+
(Reporter)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
What should I do now?
(Reporter)

Comment 8

2 years ago
I think everything is good but waiting for landing patch.

Maybe next patch you can try MozReview to send patch for reviewing. (Uploading patch as attachment is still good way). Then you can understand more about development process.

Thanks!

Comment 9

2 years ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbb20776dff9
Replaced FILL_PARENT with MATCH_PARENT in VideoPlayer.java. r=walkingice0204.
Keywords: checkin-needed
(Assignee)

Comment 10

2 years ago
Any other bug I can work on in the meantime?

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cbb20776dff9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Comment 12

2 years ago
@walkingice @sebastian Is it done? If so what should I work on now?
You need to log in before you can comment on or make changes to this bug.