1324728 - While sharing link to another device, the sender device itself should be excluded from the selection list

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Attachment: selection list.png

STR:
1. Trigger a link sharing to "Send to other devices"
2. Check on the list of selection

Actual result:
The sender itself is in the list

Expected result:
The sender itself should be excluded from the list

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

This should already be the case. Did you log in multiple times on this device or do you have multiple release channels installed?

Comment 2

[Max Liu [:maliu]]

If we want to exclude sender itself from the list, we might have to provide something like "device sn - current release channel - current sync profile id" as a unique key to filter. In current design, login/out multiple times also do not reuse/replace the profile with same "device sn - current release channel" pair. That behavior also confuse user the definition of "Sync" or "Login".

Comment 3

[Richard Newman [:rnewman]]

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/overlays/service/sharemethods/SendTab.java#172

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/db/LocalTabsAccessor.java#48

This is already the case. Local clients have a null device ID, which is excluded when querying for remote clients inside SendTab. If you've ever cleared data or uninstalled Firefox, you will have duplicate client records.

Please reopen if you can see the same client after:

* Uninstalling Firefox.
* Installing Firefox.
* Creating a brand new Firefox Account.
* Trying to send a tab.

Comment 4

[Richard Newman [:rnewman]]

Re Comment 2: note that FxA has no concept of a 'device' that's the home to multiple distinct Firefox profiles/logins. Indeed, users do use FxA to send tabs between different release channels on the same device, so it's not clear that it's even desirable to try to hide different Firefoxes from the same Android device.

Most users will never see entries from Firefoxes on the same device, and those that do quite likely _want_ to see them.

Comment 5

[Richard Newman [:rnewman]]

For cleanup after signing out, see Bug 963446.