963446 - Extend SyncAccountDeletedService to handle deleting client record for Firefox Accounts + Sync 1.5

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect)

Comment 1

[Richard Newman [:rnewman]]

Michael, I seem to recall you working on this -- true?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hmm, well, I copy pasta'd the code to a FxAccountDeletedService in bug 957894 - is that acceptable?

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #2)
> Hmm, well, I copy pasta'd the code to a FxAccountDeletedService in bug
> 957894 - is that acceptable?

We do a little more for Sync 1.1: we delete the local client record, if we can.  This is a little trickier with FxA + Sync 1.5, since it's not easy to arrange to talk to a Sync 1.5 storage endpoint (we have lots of code to make that happen smoothly).  We'd like to do similar, at least in the easy cases.

Comment 4

[Richard Newman [:rnewman]]

Michael, status update?

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Richard Newman [:rnewman] from comment #4)
> Michael, status update?

My apologies - I lost track of this and haven't been actively working on it. I can probably start working on it before the end of the week, though feel free to snag it if it's urgent.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Spoke with nalexander on IRC and he mentioned this is an uncommon edge case for non-testers, so I'm going to put my efforts elsewhere. Here's some more useful info for completing this ticket:

<mcomella> rnewman: I was looking bug 963446, but I'm actually not sure what to do - what is the client record?
<nalexander> mcomella: the record in the clients collection.
<nalexander> mcomella: uploaded in SyncCLientsEngineStage.

Which means we're deleting the client record from the server.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 8

[Richard Newman [:rnewman]]

mcomella, did you end up getting this done in another bug?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Richard Newman [:rnewman] from comment #8)
> mcomella, did you end up getting this done in another bug?

No, I do not believe so.

Comment 11

[Nick Alexander :nalexander [he/him]]

markh: relevant to your interests.  See also Bug 1254643.

Comment 12

[Mark Hammond [:markh] [:mhammond]]

(In reply to Nick Alexander :nalexander from comment #11)
> markh: relevant to your interests.  See also Bug 1254643.

Thanks Nick - we've opened bug 1264498 to filter out such devices in the meantime, and longer term we hope that the FxA device concept will help further (which is bug 1250782 and bug 1254643 which you just opened)

Comment 13

[:Grisha Kruglov]

There's ongoing work to drive a lot of our UI which exposes the sync clients list by the more easily manageable FxA devices list; see Bug 1351104. I don't think this bug as described is worth the effort.