Implement ImageBitmap for TexImage

RESOLVED FIXED in Firefox 51

Status

()

Core
Canvas: WebGL
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

({dev-doc-complete})

unspecified
mozilla53
Unspecified
All
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox50 wontfix, firefox51 fixed, firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8820439 - Attachment is obsolete: true
Attachment #8820439 - Flags: review?(dmu)
Comment on attachment 8820438 [details]
Bug 1324924 - Add ImageBitmap entrypoints. -

https://reviewboard.mozilla.org/r/99924/#review100416

r=me, but this should presumably be folded with the next changeset, so we don't have non-compiling changesets in the tree.
Attachment #8820438 - Flags: review?(bzbarsky) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8820437 [details]
Bug 1324924 - ImageBitmap::ToCloneData should be const and return a UniquePtr. -

https://reviewboard.mozilla.org/r/99922/#review100450
Attachment #8820437 - Flags: review?(mtseng) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8820440 [details]
Bug 1324924 - Add implementation for ImageBitmaps. -

https://reviewboard.mozilla.org/r/99928/#review100466
Attachment #8820440 - Flags: review?(dmu) → review+

Comment 11

a year ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b721c404cec
Support ImageBitmap for Tex*Image*. (flattened) - r=bz,daoshengmu,mtseng
Keywords: dev-doc-needed
(Assignee)

Comment 12

a year ago
Created attachment 8820600 [details]
placeholder for all patches

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8820600 - Flags: review+
Attachment #8820600 - Flags: approval-mozilla-beta?
Attachment #8820600 - Flags: approval-mozilla-aurora?

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6b721c404cec
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
status-firefox51: --- → affected
status-firefox52: --- → affected
Comment on attachment 8820600 [details]
placeholder for all patches

Fix WebGL2 related issue. Beta51+ & Aurora52+. Should be in 51 beta 10.
Attachment #8820600 - Flags: approval-mozilla-beta?
Attachment #8820600 - Flags: approval-mozilla-beta+
Attachment #8820600 - Flags: approval-mozilla-aurora?
Attachment #8820600 - Flags: approval-mozilla-aurora+
Check-in: https://hg.mozilla.org/releases/mozilla-aurora/rev/0be09d72656e
status-firefox52: affected → fixed
Sorry had to back this out for WebGLRenderingContext.webidl dependency, and bustage caused by bug 1324543. This will be landed with bug 1317625 and bug 1324543.

Updated

a year ago
status-firefox52: fixed → affected
see comment 16 from iris
Flags: needinfo?(jgilbert)
(Assignee)

Comment 18

a year ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/39582d06756a
status-firefox52: affected → fixed
(Assignee)

Comment 19

a year ago
https://hg.mozilla.org/releases/mozilla-beta/rev/392343acec55
status-firefox50: --- → wontfix
status-firefox51: affected → fixed
Flags: needinfo?(jgilbert)
ImageBitmaps are already documented:
https://developer.mozilla.org/en-US/docs/Web/API/ImageBitmap

Added WebGL method reference docs:
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/texImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/texSubImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGL2RenderingContext/texImage3D
https://developer.mozilla.org/en-US/docs/Web/API/WebGL2RenderingContext/texSubImage3D

Developer release notes entry:
https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.