1325023 - Add more channel layout to cubeb

Status: RESOLVED DUPLICATE of bug 1368938

(Core :: Audio/Video: cubeb, task, P3)

Description

[C.M.Chang[:chunmin]]

The 5.1 surround sound has two possible layout:
- Left, Right, Center, Low Frequency Effects, Left Surround, Right Surround -> 3F2-LFE
- Left, Right, Center, Low Frequency Effects, Rear Left Surround, Rear Right Surround -> ??

We only support the first one in cubeb. The first one is defined in SMPTE, however, some device vendor might use the second layout. It would be better if we could handle it in cubeb.

Comment 1

[Danial Horton]

Any work on this?

i just reported bug 1368938 which seems to be due to the lack of the second case.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[C.M.Chang[:chunmin]]

I think this should work now since we've updated the channel layout at some point in the past. We should close this if bug 1368938 is solved.

Comment 4

[Laurence "GreenReaper" Parry]

Hope this is the right place: I'm still seeing an audio codec failure on a Picarto.tv stream which caused it to repeatedly reload and restart. I was on Developer Edition 69.0b11.

NS_ERROR_DOM_MEDIA_FATAL_ERROR
Details: error creating Audio decoder.

VLC can decode the stream and reports that it is 'f32l' 44100 Hz 3F2M2R/LFE frame=1 samples/32 bytes. Presumably MPEG AAC 7.1 Audio (mp4a) with three front including one in the center and two side and two rear as well as the bass?

It seems like this should be CUBEB_LAYOUT_3F4_LFE but I don't know if it's being matched or appropriately. Maybe it needs
_3F2M2R_LFE => CUBEB_LAYOUT_3F4_LFE
as well as
_3F4_LFE => CUBEB_LAYOUT_3F4_LFE

I was using a Surface Pro (original) on Windows 10 1903 18362.267 to run this, in case it matters.

Also kinda annoying that it didn't just let me play the video without the audio, especially as I don't think they were actually playing anything.

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Laurence, it may be useful to create a new bug to track that issue. If I recall correctly, 7+ channel audio on Windows can be difficult because we rely on Microsoft's decoders there for AAC, and they don't handle such audio.

Comment 6

[C.M.Chang[:chunmin]]

We've supported any kind of channel layout of the speakers on macOS. The non-SMPTE layout on Windows will be solved in bug 1368938