Open Bug 1073786 Opened 7 years ago Updated 8 months ago

[meta] Multiple channel support for Cubeb

Categories

(Core :: Audio/Video: cubeb, enhancement, P3)

35 Branch
x86_64
Windows 8.1
enhancement

Tracking

()

People

(Reporter: sebastian.fisahn, Assigned: chunmin)

References

(Depends on 7 open bugs, Blocks 1 open bug)

Details

(Keywords: meta)

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140926185533

Steps to reproduce:

see details here: https://support.mozilla.org/en-US/questions/1020526?esab=a&s=&r=0&as=s


Actual results:

see details: https://support.mozilla.org/en-US/questions/1020526?esab=a&s=&r=0&as=s


Expected results:

see details: https://support.mozilla.org/en-US/questions/1020526?esab=a&s=&r=0&as=s
Severity: normal → major
Currently Firefox is now the only major browser not supporting multichannel AAC audio.
Maybe we can get past this problem soon.
We provide high performance high quality streaming audio encoders to many of the largest content providers. We have test HLS streams available upon request. The surround streams unfortunately, play in 2 channels using Firefox. We need multichannel AAC decoding! This would be easy to do now that Firefox is MSE compatible.
Our test multichannel AAC HLS streams currently play using Microsoft Edge, IE for Win 8/10, Safari Mac OS X and iOS, and Google Chrome. It sure would be good to add Firefox to this list.
Please let me know if we can be of assistance to make this happen.
Here are test resources:
https://www2.iis.fraunhofer.de/AAC/
https://www.indexcom.com/products/encoder/
As per irc conversation with :kinetik, it's better to start from cubeb[0] 
1. [cubeb] Support 5.1 on one backend(OS X, Linux, Windows, Android) and write tests for it
2. [cubeb] Make it work on other platforms
3. [gecko] Integrate it on Gecko side in AudioStream up to AudioConverter

[0] https://github.com/kinetiknz/cubeb
Assignee: nobody → cchang
Component: General → Audio/Video
See Also: → 706327
@cchang -- I'd like to make this bug into a meta bug for adding 5.1 support to cubeb.  Can you spin off bugs for each platform?  I'd love if we could do Windows first because it will have the greatest impact, but I realize it may be faster/easier to do one of the other platforms first.  Do you know if there is a meta bug for 5.1 support in Core:Audio/Video:Playback?  Thanks!
Status: UNCONFIRMED → NEW
Rank: 21
Component: Audio/Video → Audio/Video: cubeb
Ever confirmed: true
Flags: needinfo?(cchang)
Keywords: meta
Priority: -- → P2
(In reply to Maire Reavy [:mreavy] from comment #3)
> @cchang -- I'd like to make this bug into a meta bug for adding 5.1 support
> to cubeb.  Can you spin off bugs for each platform?  
OK, I will open new bugs for each platform.
> I'd love if we could do Windows first because it will have the greatest impact, 
> but I realize it may be faster/easier to do one of the other platforms first.
I don't have window in hand. I'd like to do that if I can get one.
> Do you know if there is a meta bug for 5.1 support in Core:Audio/Video:Playback?  Thanks!
I don't find it on bugzilla. Maybe we should open one for it. Bug 706327 is also a meta for Core:Audio/Video:cubeb to support multiple channels. Do we need to set dependency between these two bugs?
Flags: needinfo?(cchang) → needinfo?(mreavy)
Depends on: 1300018
Depends on: 1300021
Depends on: 1300023
Depends on: 1300024
(In reply to Chun-Min Chang[:chunmin] from comment #4)
> (In reply to Maire Reavy [:mreavy] from comment #3)
> > Do you know if there is a meta bug for 5.1 support in Core:Audio/Video:Playback?  Thanks!
> I don't find it on bugzilla. Maybe we should open one for it. Bug 706327 is
> also a meta for Core:Audio/Video:cubeb to support multiple channels. Do we
> need to set dependency between these two bugs?

Actually, I'm going to close Bug 706327 as a dup of this bug.  Can you open a new meta bug in Playback for 5.1 support and make it dependent on this bug?  Thanks so much for working on this!
Flags: needinfo?(mreavy) → needinfo?(cchang)
Duplicate of this bug: 706327
Blocks: 1300455
(In reply to Maire Reavy [:mreavy] from comment #5)
> Actually, I'm going to close Bug 706327 as a dup of this bug.  Can you open
> a new meta bug in Playback for 5.1 support and make it dependent on this
> bug?  Thanks so much for working on this!
Done. Thanks for your guide :)
Flags: needinfo?(cchang)
Summary: No 5.1 surround sound (he-aac with html5) → [meta] Multiple channel support for Cubeb
Depends on: 1318628
I open a wiki page to track the status
https://wiki.mozilla.org/Media/multichannel
Depends on: 1325023
Depends on: 1339723
Depends on: 1343788
Depends on: 1349474
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Type: defect → enhancement

This is done isn't it?

Flags: needinfo?(achronop)

The remaining parts are;

  • Bug 1325023 if it still stands. :chunmin should know about it (NI)
  • Multichannel in android. If we want it there we haven't done anything.
Flags: needinfo?(achronop) → needinfo?(cchang)

We have implemented multi-channel in Windows, Mac OS, and PulseAudio, but we don't support other platforms like Android and ALSA. I've asked the reporter of bug 1368938 to check the layout issue again. Bug 1325023 should close if bug 1368938 is solved.

Flags: needinfo?(cchang)
Depends on: 1474175
Depends on: 1368938
Depends on: 1619726
Depends on: 1627827
Depends on: 1552928

I find the same questions for audio channel layout setting come times and times again and reporters usually don't know how to check those settings. To avoid answering the same questions again and again, I wrote a FAQ post to address some common issues. I hope we can paste that post to answer the reporter's issues directly in the future.

I am not sure where I can post the official FAQ page, so I just post it on my blog for now. Here is the link: https://chunminchang.github.io/blog/post/firefox-faq-audio-channel-layout

That post include some common issues:

  • how to set up and check the audio channel layout
  • how to file a bug with info that helps us to address the reporter's issues

The FAQ is mainly for Mac OS now. I'll add the Windows and Linux parts in the future.

You need to log in before you can comment on or make changes to this bug.