Closed Bug 1325053 Opened 6 years ago Closed 6 years ago

Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement to follow WhatWG HTML.

Categories

(Testing :: web-platform-tests, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ctai, Assigned: ctai)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement to follow WhatWG HTML. See https://html.spec.whatwg.org/#loading-the-media-resource
XHR work around try result for this bug:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa0ca09ca185f228c2d492d67a95e7591646b5e&selectedJob=33228764

Looks like the media code works well.
So we can land those fixes to align current media code with current WhatWG HTML spec.
Since the media attribute is removed from source element in video element case. The test case of dom/media/test/test_source_media.html should be removed too.

dom/media/test/test_source_media.html fail: https://treeherder.mozilla.org/logviewer.html#?job_id=33230724&repo=try#L4717
Comment on attachment 8820713 [details]
Bug 1325053 - Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement.

https://reviewboard.mozilla.org/r/100172/#review100898
Attachment #8820713 - Flags: review?(jwwang) → review+
Comment on attachment 8820714 [details]
Bug 1325053 - Enable video_008.htm.

https://reviewboard.mozilla.org/r/100174/#review100900
Attachment #8820714 - Flags: review?(jwwang) → review+
Comment on attachment 8820751 [details]
Bug 1325053 - Remove test_source_media.html.

https://reviewboard.mozilla.org/r/100190/#review100902
Attachment #8820751 - Flags: review?(jwwang) → review+
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/554c43ddc7a6
Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/a7f92ff6ea76
Enable video_008.htm. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/dc933c5fe7df
Remove test_source_media.html. r=jwwang
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.