1325053 - Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement to follow WhatWG HTML.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement to follow WhatWG HTML. See https://html.spec.whatwg.org/#loading-the-media-resource

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://www.w3.org/Bugs/Public/show_bug.cgi?id=19619

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

XHR work around try result for this bug:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa0ca09ca185f228c2d492d67a95e7591646b5e&selectedJob=33228764

Looks like the media code works well.
So we can land those fixes to align current media code with current WhatWG HTML spec.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1325053 - Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement.

According to current WhatWG HTML spec, the checking of media attribute in SourceElement is removed. Fix the Gecko code to reflect current spec.

Review commit: https://reviewboard.mozilla.org/r/100172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100172/

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1325053 - Enable video_008.htm.

This bug also fix test case video_008.htm.

Review commit: https://reviewboard.mozilla.org/r/100174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100174/

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Since the media attribute is removed from source element in video element case. The test case of dom/media/test/test_source_media.html should be removed too.

dom/media/test/test_source_media.html fail: https://treeherder.mozilla.org/logviewer.html#?job_id=33230724&repo=try#L4717

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1325053 - Remove test_source_media.html.

The media attribute in source element is no longer needed in media element case. Remove related test case.

Review commit: https://reviewboard.mozilla.org/r/100190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100190/

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Latest try result with work around: https://treeherder.mozilla.org/#/jobs?repo=try&revision=97de9fafefb8f0074c46e5e894daf40e1783fb58&selectedJob=33237942

All green. LGTM.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8820713 [details]
Bug 1325053 - Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement.

https://reviewboard.mozilla.org/r/100172/#review100898

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8820714 [details]
Bug 1325053 - Enable video_008.htm.

https://reviewboard.mozilla.org/r/100174/#review100900

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8820751 [details]
Bug 1325053 - Remove test_source_media.html.

https://reviewboard.mozilla.org/r/100190/#review100902

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/554c43ddc7a6
Remove media attribute code and set the currentSrc attribute to urlString after type checking in HTMLMediaElement. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/a7f92ff6ea76
Enable video_008.htm. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/dc933c5fe7df
Remove test_source_media.html. r=jwwang

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/554c43ddc7a6
https://hg.mozilla.org/mozilla-central/rev/a7f92ff6ea76
https://hg.mozilla.org/mozilla-central/rev/dc933c5fe7df