1325118 - Flash crashes in Windows debug builds

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Robin Steuber (they/them) [:bytesized]]

To reproduce:
(System: Windows 10)

mozconfig:
ac_add_options --target=i686-pc-mingw32
ac_add_options --host=i686-pc-mingw32
ac_add_options --enable-debug
ac_add_options --disable-optimize

build with |./mach clobber; ./mach build|
run with |./mach run|

Then load a flash file. I have tried these:
 a) Drag-and-drop mozilla-central/testing/web-platform/tests/content-security-policy/support/media/flash.swf  into the browser
 b) Navigate to http://www.kongregate.com/games/Ninjakiwi/bloons-td-5

The Flash process immediately crashes. Retrying yields the same results.

Rebuilding with this mozconfig allows Flash to run as expected:
ac_add_options --target=i686-pc-mingw32
ac_add_options --host=i686-pc-mingw32

Comment 1

[Benjamin Smedberg]

Presumably you hit some sort of assert? Do you have a stack from where the process exited?

Comment 2

[Robin Steuber (they/them) [:bytesized]]

Ah. It looks like you are right:

Assertion failure: !IsUsingDirectDrawing(), at c:/mozilla-central/dom/plugins/ipc/PluginInstanceChild.cpp:3817
#01: mozilla::plugins::PluginInstanceChild::InvalidateRectDelayed (c:\mozilla-central\dom\plugins\ipc\plugininstancechild.cpp:4085)
#02: mozilla::detail::RunnableMethodArguments<>::applyImpl<mozilla::plugins::PluginInstanceChild,void (__thiscall mozilla::plugins::PluginInstanceChild::*)(void)> (c:\mozilla-central\obj-i686-pc-mingw32\dist\include\nsthreadutils.h:792)
#03: mozilla::detail::RunnableMethodArguments<>::apply<mozilla::plugins::PluginInstanceChild,void (__thiscall mozilla::plugins::PluginInstanceChild::*)(void)> (c:\mozilla-central\obj-i686-pc-mingw32\dist\include\nsthreadutils.h:797)
#04: mozilla::detail::RunnableMethodImpl<void (__thiscall mozilla::plugins::PluginInstanceChild::*)(void),0,1>::Run (c:\mozilla-central\obj-i686-pc-mingw32\dist\include\nsthreadutils.h:828)
#05: MessageLoop::RunTask (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:353)
#06: MessageLoop::DeferOrRunPendingTask (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:363)
#07: MessageLoop::DoWork (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:435)
#08: base::MessagePumpForUI::DoRunLoop (c:\mozilla-central\ipc\chromium\src\base\message_pump_win.cc:212)
#09: base::MessagePumpWin::RunWithDispatcher (c:\mozilla-central\ipc\chromium\src\base\message_pump_win.cc:58)
#10: base::MessagePumpWin::Run (c:\mozilla-central\ipc\chromium\src\base\message_pump_win.h:80)
#11: MessageLoop::RunInternal (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:233)
#12: MessageLoop::RunHandler (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:219)
#13: MessageLoop::Run (c:\mozilla-central\ipc\chromium\src\base\message_loop.cc:206)
#14: XRE_InitChildProcess (c:\mozilla-central\toolkit\xre\nsembedfunctions.cpp:760)
#15: content_process_main (c:\mozilla-central\ipc\contentproc\plugin-container.cpp:115)
#16: NS_internal_main (c:\mozilla-central\ipc\app\mozillaruntimemain.cpp:18)
#17: wmain (c:\mozilla-central\toolkit\xre\nswindowswmain.cpp:111)
#18: __scrt_common_main_seh (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
#19: BaseThreadInitThunk[C:\WINDOWS\SYSTEM32\KERNEL32.DLL +0x138f4]
#20: RtlUnicodeStringToInteger[C:\WINDOWS\SYSTEM32\ntdll.dll +0x65de3]
#21: RtlUnicodeStringToInteger[C:\WINDOWS\SYSTEM32\ntdll.dll +0x65dae]

Comment 3

[Jim Mathies [:jimm]]

hmmph, not having any luck reproducing.

Comment 4

[Robin Steuber (they/them) [:bytesized]]

@jimm I tried it with a new build and it no longer happens for me either.