Closed
Bug 1229961
Opened 5 years ago
Closed 5 years ago
Enable direct plugin drawing by default
Categories
(Core :: Plug-ins, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Depends on 1 open bug)
Details
(Keywords: site-compat)
Attachments
(2 files)
5.78 KB,
patch
|
aklotz
:
review+
vladan
:
review+
|
Details | Diff | Splinter Review |
1.75 KB,
patch
|
aklotz
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•5 years ago
|
||
As part of turning this on, I'd like to have Telemetry on how often each drawing mode gets used. Which is a little tricky, since the drawing mode can change, so I tried to hook the places where we're about to draw something.
Attachment #8695003 -
Flags: review?(aklotz)
![]() |
Assignee | |
Comment 2•5 years ago
|
||
Comment on attachment 8695003 [details] [diff] [review] part 1, telemetry Vladan for the histogram changes.
Attachment #8695003 -
Flags: review?(vladan.bugzilla)
![]() |
Assignee | |
Comment 3•5 years ago
|
||
Attachment #8695004 -
Flags: review?(aklotz)
Updated•5 years ago
|
Attachment #8695003 -
Flags: review?(vladan.bugzilla) → review+
Comment 4•5 years ago
|
||
Comment on attachment 8695003 [details] [diff] [review] part 1, telemetry Review of attachment 8695003 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/Histograms.json @@ +10143,5 @@ > + "alert_emails": ["danderson@mozilla.com"], > + "expires_in_version": "never", > + "kind": "enumerated", > + "bug_numbers": [1229961], > + "n_values": 20, This seems a bit high. Can we drop this to 12 or something?
Attachment #8695003 -
Flags: review?(aklotz) → review+
Updated•5 years ago
|
Attachment #8695004 -
Flags: review?(aklotz) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/deae83275ac7 https://hg.mozilla.org/integration/mozilla-inbound/rev/a1bd47d76f71
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/deae83275ac7 https://hg.mozilla.org/mozilla-central/rev/a1bd47d76f71
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
We need to find someone who can own fixing these regressions. I suspect David is too busy with the OOP compositor work right now.
Flags: needinfo?(blassey.bugs)
Another report: https://support.mozilla.org/en-US/questions/1143850
Is it possible to backout this feature to add it later after finding a workaround or fixing all the regressions? Many reports have been filed on BMO/SUMO and it affects popular websites like Facebook or news websites when playing game/videos.
Comment 10•4 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/some-flash-content-is-broken-due-to-async-rendering-mode/
Keywords: site-compat
We're going to discuss this and bug 1307108 today. Thanks Loic!
Flags: needinfo?(lhenry)
Updated•4 years ago
|
Flags: needinfo?(blassey.bugs)
![]() |
||
Updated•4 years ago
|
Updated•4 years ago
|
Depends on: flash-async-drawing
![]() |
||
Updated•4 years ago
|
No longer depends on: flash-async-drawing
You need to log in
before you can comment on or make changes to this bug.
Description
•