1229961 - Enable direct plugin drawing by default

Status: RESOLVED FIXED

(Core :: Plug-ins, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, telemetry

As part of turning this on, I'd like to have Telemetry on how often each drawing mode gets used. Which is a little tricky, since the drawing mode can change, so I tried to hook the places where we're about to draw something.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8695003 [details] [diff] [review]
part 1, telemetry

Vladan for the histogram changes.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, pref flip

Comment 4

[Aaron Klotz [:aklotz]]

Comment on attachment 8695003 [details] [diff] [review]
part 1, telemetry

Review of attachment 8695003 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +10143,5 @@
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "never",
> +    "kind": "enumerated",
> +    "bug_numbers": [1229961],
> +    "n_values": 20,

This seems a bit high. Can we drop this to 12 or something?

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/deae83275ac7
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1bd47d76f71

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/deae83275ac7
https://hg.mozilla.org/mozilla-central/rev/a1bd47d76f71

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

We need to find someone who can own fixing these regressions. I suspect David is too busy with the OOP compositor work right now.

Comment 8

[Loic]

Another report:
https://support.mozilla.org/en-US/questions/1143850

Comment 9

[Loic]

Is it possible to backout this feature to add it later after finding a workaround or fixing all the regressions? Many reports have been filed on BMO/SUMO and it affects popular websites like Facebook or news websites when playing game/videos.

Comment 10

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/some-flash-content-is-broken-due-to-async-rendering-mode/

Comment 11

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

We're going to discuss this and bug 1307108 today. Thanks Loic!