1325234 - DeCOMtaminate nsIWidget for the last time

Status: RESOLVED FIXED

(Core :: Widget, defect, P3)

Description

[Nicholas Nethercote [inactive]]

Continuing on from bug 1299335.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Streamline nsIWidget::NotifyIME

This patch changes it from |NS_IMETHOD| to |virtual nsresult|. The callsites
were a mix of checked and unchecked so using |MOZ_MUST_USE| didn't feel
appropriate.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Streamline nsIWidget::Invalidate()

This patch changes it from |NS_IMETHOD| to |virtual void|. The return value was
only checked in one low-value assertion so I decided it wasn't needed.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Streamline nsIWidget::Show()

This patch changes it from |NS_IMETHOD| to |virtual void|. The return value was
only checked in one low-value assertion and one other place where the check had
no useful effect (nsCocoaWindow::HideWindowChrome()).

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Streamline nsIWidget::{SetFocus,SetNonClientMargins}()

This patch changes them from |NS_IMETHOD| to |virtual nsresult|.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Streamline nsIWidget::SetCursor (both versions)

This patch changes one from |NS_IMETHOD| to |virtual nsresult| and the other to
|virtual void|.

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 6) - Streamline nsIWidget::SetTitle

This patch changes it from |NS_IMETHOD| to |virtual nsresult| because some call
sites are checked and others aren't.

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: (part 7) - Streamline nsIWidget::GetSelectionAsPlaintext

This patch changes it from |NS_IMETHOD| to |virtual MOZ_MUST_USE nsresult|.

Comment 8

[Nicholas Nethercote [inactive]]

Attachment: (part 8) - Streamline nsIWidget::DispatchEvent

This patch changes it from |NS_IMETHOD| to |virtual nsresult| because some
callsites are checked and some aren't.

Comment 9

[Nicholas Nethercote [inactive]]

Attachment: (part 9) - Remove remaining NS_IMETHOD_ occurrences from nsIWidget

|virtual T| is clearer than |NS_IMETHOD_(T)|.

Comment 10

[Nicholas Nethercote [inactive]]

Attachment: (part 10) - Final nsIWidget deCOMtamination clean-ups

This patch converts some NS_IMETHOD and NS_IMETHODIMP occurrences that I missed
in previous bugs.

The patch also removes the Android
nsWindow::{Get,Set}HasTransparentBackground() functions because they're unused.

Comment 11

[Markus Stange [:mstange]]

Comment on attachment 8820964 [details] [diff] [review]
(part 9) - Remove remaining NS_IMETHOD_ occurrences from nsIWidget

Review of attachment 8820964 [details] [diff] [review]:
-----------------------------------------------------------------

I had no idea NS_IMETHOD_(T) even existed. That's wild.

Comment 12

[Jim Mathies [:jimm]]

Comment on attachment 8820963 [details] [diff] [review]
(part 8) - Streamline nsIWidget::DispatchEvent

Review of attachment 8820963 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaWindow.mm
@@ +1887,5 @@
>    return NS_OK;
>  }
>  
>  // Invokes callback and ProcessEvent methods on Event Listener object
> +nsresult 

nit - trailing whitespace

Comment 13

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9fc4ad67f3ddcd876962cb9fa8f4f950b5abeec
Bug 1325234 (part 1) - Streamline nsIWidget::NotifyIME. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8da1583fcd48bc11ff425300a31ed220b96fb415
Bug 1325234 (part 2) - Streamline nsIWidget::Invalidate(). r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4181e317c8df04f18dd85eac8d8922b1d4e41f6
Bug 1325234 (part 3) - Streamline nsIWidget::Show(). r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/445cae8045dec19f197ea08c80f6e4d17fc336d7
Bug 1325234 (part 4) - Streamline nsIWidget::{SetFocus,SetNonClientMargins}(). r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/75544504b0012d30bbee73fd73fea1ac5c85de03
Bug 1325234 (part 5) - Streamline nsIWidget::SetCursor (both versions). r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/407b4fc54cd5009d3c434565b7a249390c7c5005
Bug 1325234 (part 6) - Streamline nsIWidget::SetTitle. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/48f5a494d7edf85ee57f329ee75d83d874042294
Bug 1325234 (part 7) - Streamline nsIWidget::GetSelectionAsPlaintext. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad2e4c9148888815661208134b21bd22f34986b
Bug 1325234 (part 8) - Streamline nsIWidget::DispatchEvent. r=jimm.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e51e167058e06429deb642480c0c5691715601e
Bug 1325234 (part 9) - Remove remaining NS_IMETHOD_ occurrences from nsIWidget. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c419cd68dcc95fb63f43bcaf117995ae77f638f
Bug 1325234 (part 10) - Final nsIWidget deCOMtamination clean-ups. r=mstange.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9fc4ad67f3d
https://hg.mozilla.org/mozilla-central/rev/8da1583fcd48
https://hg.mozilla.org/mozilla-central/rev/b4181e317c8d
https://hg.mozilla.org/mozilla-central/rev/445cae8045de
https://hg.mozilla.org/mozilla-central/rev/75544504b001
https://hg.mozilla.org/mozilla-central/rev/407b4fc54cd5
https://hg.mozilla.org/mozilla-central/rev/48f5a494d7ed
https://hg.mozilla.org/mozilla-central/rev/3ad2e4c91488
https://hg.mozilla.org/mozilla-central/rev/1e51e167058e
https://hg.mozilla.org/mozilla-central/rev/1c419cd68dcc