[EME][Fennec] Pref on EME API and make Widevine only support on M+ android version

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: kikuo, Assigned: JamesCheng)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

4 months ago
So that Fennec could be able to watch DRM content via Widevine CDM (if it's already downloaded)
(Assignee)

Updated

4 months ago
Summary: [EME][Fennec] Pref on EME API → [EME][Fennec] Pref on EME API and make Widevine only support on M+ android version
Comment hidden (mozreview-request)
Priority: -- → P3
(Assignee)

Comment 2

4 months ago
After testing the current code on central by Shaka demo player and bitmovin DRM Test page,
we can successfully play widevine DRM content on Fennec.

Therefore, we decided to turn on the EME API on nightly to see if any potential issues and start to fix the issue on nightly. 

I will start to work on 
Bug 1302025 - (EME_Telemetry) Add telemetry to know how many users use EME on Fennec for DRM

to see the real use case of DRM on Fennec.
(Assignee)

Comment 3

4 months ago
The Widevine DRM is supported on M+ android devices.

The patch also handled this part.
(Assignee)

Updated

4 months ago
Attachment #8821465 - Flags: review?(cpearce)
(Assignee)

Updated

4 months ago
Depends on: 1325543

Comment 4

4 months ago
mozreview-review
Comment on attachment 8821465 [details]
Bug 1325332 - [EME][Fennec] Pref on EME API and only support it for M+ android version.

https://reviewboard.mozilla.org/r/100774/#review103668

Good job making this all work.
Attachment #8821465 - Flags: review?(cpearce) → review+
(Assignee)

Updated

3 months ago
Blocks: 1329557
(Assignee)

Comment 5

3 months ago
Thank you Chris for your guidance and advice for these works.

I create a follow-up Bug 1329557 for enabling the EME API on all branches not only on Nightly once we observe the Widevine solution works fine for nightly-end-users.

Comment 6

3 months ago
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c273666082fa
[EME][Fennec] Pref on EME API and only support it for M+ android version. r=cpearce
Backed out in https://hg.mozilla.org/integration/autoland/rev/b1576b5adad1 - that exposes a bunch of media properties which weren't previously exposed on Android, https://treeherder.mozilla.org/logviewer.html#?job_id=67153260&repo=autoland, so you have to update dom/tests/mochitest/general/test_interfaces.html and have a DOM peer review the fact that you meant to expose them.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8824920 - Flags: review?(bugs)
(Assignee)

Comment 10

3 months ago
Hi smaug,
Please review this patch since we have finished implementing the EME related API on Fennec so we should remove the constrain in this test file.

Thank you.
(Assignee)

Comment 11

3 months ago
Attach treeherder result,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=015940f6b5c12822402c7f1300faf59ca9243e8e

Comment 12

3 months ago
mozreview-review
Comment on attachment 8824920 [details]
Bug 1325332 - Remove EME API disabled on android constrain

https://reviewboard.mozilla.org/r/103258/#review104050
Attachment #8824920 - Flags: review?(bugs) → review+

Comment 13

3 months ago
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ccfba29a819
[EME][Fennec] Pref on EME API and only support it for M+ android version. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/acd4177b28d7
Remove EME API disabled on android constrain r=smaug

Comment 14

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8ccfba29a819
https://hg.mozilla.org/mozilla-central/rev/acd4177b28d7
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.