1325332 - [EME][Fennec] Pref on EME API and make Widevine only support on M+ android version

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

So that Fennec could be able to watch DRM content via Widevine CDM (if it's already downloaded)

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1325332 - [EME][Fennec] Pref on EME API and only support it for M+ android version.

Review commit: https://reviewboard.mozilla.org/r/100774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100774/

Comment 2

[James Cheng[:JamesCheng]]

After testing the current code on central by Shaka demo player and bitmovin DRM Test page,
we can successfully play widevine DRM content on Fennec.

Therefore, we decided to turn on the EME API on nightly to see if any potential issues and start to fix the issue on nightly. 

I will start to work on 
Bug 1302025 - (EME_Telemetry) Add telemetry to know how many users use EME on Fennec for DRM

to see the real use case of DRM on Fennec.

Comment 3

[James Cheng[:JamesCheng]]

The Widevine DRM is supported on M+ android devices.

The patch also handled this part.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8821465 [details]
Bug 1325332 - [EME][Fennec] Pref on EME API and only support it for M+ android version.

https://reviewboard.mozilla.org/r/100774/#review103668

Good job making this all work.

Comment 5

[James Cheng[:JamesCheng]]

Thank you Chris for your guidance and advice for these works.

I create a follow-up Bug 1329557 for enabling the EME API on all branches not only on Nightly once we observe the Widevine solution works fine for nightly-end-users.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c273666082fa
[EME][Fennec] Pref on EME API and only support it for M+ android version. r=cpearce

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/b1576b5adad1 - that exposes a bunch of media properties which weren't previously exposed on Android, https://treeherder.mozilla.org/logviewer.html#?job_id=67153260&repo=autoland, so you have to update dom/tests/mochitest/general/test_interfaces.html and have a DOM peer review the fact that you meant to expose them.

Comment 8

[James Cheng[:JamesCheng]]

Attachment: Bug 1325332 - Remove EME API disabled on android constrain

Review commit: https://reviewboard.mozilla.org/r/103258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103258/

Comment 9

[James Cheng[:JamesCheng]]

Comment on attachment 8821465 [details]
Bug 1325332 - [EME][Fennec] Pref on EME API and only support it for M+ android version.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100774/diff/1-2/

Comment 10

[James Cheng[:JamesCheng]]

Hi smaug,
Please review this patch since we have finished implementing the EME related API on Fennec so we should remove the constrain in this test file.

Thank you.

Comment 11

[James Cheng[:JamesCheng]]

Attach treeherder result,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=015940f6b5c12822402c7f1300faf59ca9243e8e

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8824920 [details]
Bug 1325332 - Remove EME API disabled on android constrain

https://reviewboard.mozilla.org/r/103258/#review104050

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ccfba29a819
[EME][Fennec] Pref on EME API and only support it for M+ android version. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/acd4177b28d7
Remove EME API disabled on android constrain r=smaug

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ccfba29a819
https://hg.mozilla.org/mozilla-central/rev/acd4177b28d7