1325543 - [EME][Fennec] Avoid unnecessarily awaiting for Widevine CDM installation.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Kilik Kuo [:kikuo] (inactive)]

On Fennec, if the key system(widevine) is not supported by MediaDrm or the minimal API level doesn't meet 23(M), we should return cdm_not_supported instead of cdm_not_installed to avoid the following awaiting procedure.  Because the awaiting procedure results to a blank combobox UI (http://www.shaka-player-demo.appspot.com/demo/) for 1 minute.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation.

Review commit: https://reviewboard.mozilla.org/r/100736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100736/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8821446 [details]
Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation.

https://reviewboard.mozilla.org/r/100736/#review101804

::: dom/media/eme/MediaKeySystemAccess.cpp:174
(Diff revision 1)
>      } else if (Preferences::GetBool("media.mediadrm-widevinecdm.visible", false)) {
>          nsCString keySystem = NS_ConvertUTF16toUTF8(aKeySystem);
>          bool supported = mozilla::java::MediaDrmProxy::IsSchemeSupported(keySystem);
>          if (!supported) {
> -          aOutMessage = NS_LITERAL_CSTRING("Widevine CDM is not available");
> -          return MediaKeySystemStatus::Cdm_not_installed;
> +          aOutMessage = NS_LITERAL_CSTRING("KeySystem or Minimum API level not met for Widevine EME");
> +          return MediaKeySystemStatus::Cdm_not_supported;

Please explain the change in more details in the commit message. It is not obvious how the return value changes the CDM installation procedure.

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8821446 [details]
Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100736/diff/1-2/

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8821446 [details]
Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation.

https://reviewboard.mozilla.org/r/100734/#review101818

Thanks for review, I added more information in commit message.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e01536096209
Avoid unnecessarily awaiting procedure for Widevine CDM installation. r=jwwang

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e01536096209