Closed
Bug 1325543
Opened 7 years ago
Closed 7 years ago
[EME][Fennec] Avoid unnecessarily awaiting for Widevine CDM installation.
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: kikuo, Assigned: kikuo)
References
Details
Attachments
(1 file)
On Fennec, if the key system(widevine) is not supported by MediaDrm or the minimal API level doesn't meet 23(M), we should return cdm_not_supported instead of cdm_not_installed to avoid the following awaiting procedure. Because the awaiting procedure results to a blank combobox UI (http://www.shaka-player-demo.appspot.com/demo/) for 1 minute.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Blocks: Widevine_on_Fennec
Assignee | ||
Updated•7 years ago
|
Attachment #8821446 -
Flags: review?(jwwang)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8821446 [details] Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation. https://reviewboard.mozilla.org/r/100736/#review101804 ::: dom/media/eme/MediaKeySystemAccess.cpp:174 (Diff revision 1) > } else if (Preferences::GetBool("media.mediadrm-widevinecdm.visible", false)) { > nsCString keySystem = NS_ConvertUTF16toUTF8(aKeySystem); > bool supported = mozilla::java::MediaDrmProxy::IsSchemeSupported(keySystem); > if (!supported) { > - aOutMessage = NS_LITERAL_CSTRING("Widevine CDM is not available"); > - return MediaKeySystemStatus::Cdm_not_installed; > + aOutMessage = NS_LITERAL_CSTRING("KeySystem or Minimum API level not met for Widevine EME"); > + return MediaKeySystemStatus::Cdm_not_supported; Please explain the change in more details in the commit message. It is not obvious how the return value changes the CDM installation procedure.
Attachment #8821446 -
Flags: review?(jwwang) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8821446 [details] Bug 1325543 - Avoid unnecessarily awaiting procedure for Widevine CDM installation. https://reviewboard.mozilla.org/r/100734/#review101818 Thanks for review, I added more information in commit message.
Pushed by kikuo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e01536096209 Avoid unnecessarily awaiting procedure for Widevine CDM installation. r=jwwang
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e01536096209
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•