1325375 - Activity stream - Context menu is not displayed when tapping the 3 dots menu icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Environment: 
Device: Asus Transformer Pad (Android 4.2.1);
Build: latest Nightly 53.0a1 (2016-12-21);

Prerequisites: Activity stream enabled.

Steps to reproduce:
1. Launch Firefox;
2. Tap on the 3 dots menu icon of a website from Activity stream panel (either Top sites or Highlights area);

Expected result:
Context menu is properly displayed.

Actual result:
Nothing happens, the context menu is not displayed.

Notes:
This issue is reproducible only on Asus Transformer Pad; on Nexus 9 (Android 7.0) and Asus ZenPad (6.0.1) the context menu is displayed when tapping the 3 dots menu.

Comment 1

[Andrzej Hunt :ahunt]

This one is looking like good fun: once I get the PopupWindow to show (we don't set a height/width by default, so somehow the PopupWindow decides not to show on the Asus devices), I run into:
https://code.google.com/p/android/issues/detail?id=190498

Comment 2

[Andrzej Hunt :ahunt]

I'm not getting very far with fixing the weird borders, so I'll focus on just making the menu visible here - I've filed bug 1333545 to then fix the appearance.

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1325375 - Followup: extend popupmenu size workaround to all 4/5 devices

Review commit: https://reviewboard.mozilla.org/r/106948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106948/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8830004 [details]
Bug 1325375 - Followup: extend popupmenu size workaround to all 4/5 devices

https://reviewboard.mozilla.org/r/106948/#review108208

Argh.

Isn't our main menu a PopupWindow too?

Comment 5

[Andrzej Hunt :ahunt]

Comment on attachment 8830004 [details]
Bug 1325375 - Followup: extend popupmenu size workaround to all 4/5 devices

https://reviewboard.mozilla.org/r/106948/#review108208

Yup - it seems all the other PopupWindow users already set WRAP_CONTENT themselves:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/menu/MenuPopup.java#38
and:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/widget/AnchoredPopup.java?q=path%3AAnchoredPopup&redirect_type=single#57

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8332dc26820c
Make PopupContextMenu visible on Android 4 Asus tablets r=sebastian

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8332dc26820c

Comment 9

[Oana Horvath [:ohorvath]]

The issue was fixed on Asus Transformers Pad (Android 4.2.1). 
Still reproducing on tablets, I was able to reproduce it on the following devices: 
- Lenovo Yoga Tablet 2 (Android 4.4.2);
- Xiaomi Mi Pad 2 (Android 5.1, x86);
- Huawei MediaPad M2 (Android 5.1.1).

Comment 10

[Andrzej Hunt :ahunt]

Comment on attachment 8830004 [details]
Bug 1325375 - Followup: extend popupmenu size workaround to all 4/5 devices

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106948/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbf09755c433
Followup: extend popupmenu size workaround to all 4/5 devices r=sebastian

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dbf09755c433

Comment 13

[Carmen Fat [:cfat] - Ecosystem QA]

Tested with the latest Nightly build 54.0a1 (2017-02-16) using the following devices:
- Huawei MediaPad M2 (Android 5.1.1);
- Xiaomi Mi Pad 2 (Android 5.1, x86);
- Lenovo Yoga Tablet 2 (Android 4.4.2);
- Asus Transformer Pad (Android 4.2.1).

Context menu is now displayed after tapping the 3 dots menu icon (for both Top sites and Highlights).

I'm marking this as Verified.