1325447 - WebRTC.org Update49 forced the SSRC down via config, and that blocks collision handling

Status: NEW

(Core :: WebRTC, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Because the webrtc.org 49 update (Bug 1250356) sets the SSRC to a random 32-bit value in the config structure (and apparently has to set it), this causes rtp_sender.cc's SetSSRC() to be called, which sets ssrc_forced.  That means that the SSRC is forced forever, and even a collision won't change it (!)

It would be better for the random SSRC to be generated by the RTP code and recorded in the RTP SSRC database for the stream, to avoid collisions (and allow for reconfiguring SSRC on a collision, though care is needed in handling this in webrtc due to SSRCs being in negotiation).  

There looks also to be an interaction with the code to randomize timestamps.

Comment 1

[Nils Ohlmeier [:drno]]

Bumping as this appears to cause pain as reported in bug 1335469.

Comment 2

[Nils Ohlmeier [:drno]]

Randell is this fixed now through bug 1337810, or do you want to keep this open for the missing collision detection?

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

I think this should be kept open, but likely the resolution is to simply file a bug on upstream

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 5

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information