Closed Bug 1325623 Opened 4 years ago Closed 4 years ago
Fix most no-undef eslint issues in toolkit/components
59 bytes, text/x-review-board-request
As part of figuring out the no-undef issues in browser/ I took a look at toolkit/components/. A lot of what it needed was addition of various import-global-from items and adding a few missing .eslintrc.js files. There's some corrections in there for good measure as well. The remaining errors we'll need to dig into in more detail in the new year.
Oh, I forgot to say, this gets the number of no-undef issues in toolkit/components from 7476 down to 429 :-)
Comment on attachment 8821555 [details] Bug 1325623 - Fix most no-undef eslint issues in toolkit/components. https://reviewboard.mozilla.org/r/100798/#review101712 Looks good. I'm a little surprised that some of these things weren't breaking tests though.
Attachment #8821555 - Flags: review?(dtownsend) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/cfe8505e19e7 Fix most no-undef eslint issues in toolkit/components. r=mossop
You need to log in before you can comment on or make changes to this bug.