1325623 - Fix most no-undef eslint issues in toolkit/components

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Mark Banner (:standard8)]

As part of figuring out the no-undef issues in browser/ I took a look at toolkit/components/.

A lot of what it needed was addition of various import-global-from items and adding a few missing .eslintrc.js files.

There's some corrections in there for good measure as well.

The remaining errors we'll need to dig into in more detail in the new year.

Comment 1

[Mark Banner (:standard8)]

Oh, I forgot to say, this gets the number of no-undef issues in toolkit/components from 7476 down to 429 :-)

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

Review commit: https://reviewboard.mozilla.org/r/100798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100798/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100798/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100798/diff/2-3/

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100798/diff/3-4/

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

https://reviewboard.mozilla.org/r/100798/#review101712

Looks good. I'm a little surprised that some of these things weren't breaking tests though.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfe8505e19e7
Fix most no-undef eslint issues in toolkit/components. r=mossop

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cfe8505e19e7