Fix most no-undef eslint issues in toolkit/components

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
As part of figuring out the no-undef issues in browser/ I took a look at toolkit/components/.

A lot of what it needed was addition of various import-global-from items and adding a few missing .eslintrc.js files.

There's some corrections in there for good measure as well.

The remaining errors we'll need to dig into in more detail in the new year.
Assignee

Comment 1

2 years ago
Oh, I forgot to say, this gets the number of no-undef issues in toolkit/components from 7476 down to 429 :-)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

https://reviewboard.mozilla.org/r/100798/#review101712

Looks good. I'm a little surprised that some of these things weren't breaking tests though.
Attachment #8821555 - Flags: review?(dtownsend) → review+

Comment 7

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfe8505e19e7
Fix most no-undef eslint issues in toolkit/components. r=mossop

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cfe8505e19e7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.