Closed Bug 1325623 Opened 4 years ago Closed 4 years ago

Fix most no-undef eslint issues in toolkit/components

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.
59 bytes, text/x-review-board-request
mossop
: review+
Details 
As part of figuring out the no-undef issues in browser/ I took a look at toolkit/components/.

A lot of what it needed was addition of various import-global-from items and adding a few missing .eslintrc.js files.

There's some corrections in there for good measure as well.

The remaining errors we'll need to dig into in more detail in the new year.
Oh, I forgot to say, this gets the number of no-undef issues in toolkit/components from 7476 down to 429 :-)
Comment on attachment 8821555 [details]
Bug 1325623 - Fix most no-undef eslint issues in toolkit/components.

https://reviewboard.mozilla.org/r/100798/#review101712

Looks good. I'm a little surprised that some of these things weren't breaking tests though.
Attachment #8821555 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfe8505e19e7
Fix most no-undef eslint issues in toolkit/components. r=mossop
https://hg.mozilla.org/mozilla-central/rev/cfe8505e19e7
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.