1325738 - Add support for custom Prompts in Fennec

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=41018847&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/J04M1JnFR3ye0uxxSbYYfA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This failure happened in enforce_gecko_prefs() while restarting Firefox. 

Excerpt from gecko.log:

> 1482529361622	Marionette	TRACE	conn16 -> [0,12,"deleteSession",null]
> 1482529361626	Marionette	TRACE	conn16 <- [1,12,null,{}]
> [..]
> 1482529549682	Marionette	DEBUG	Marionette enabled via build flag and pref
> 1482529550202	Marionette	INFO	Listening on port 2828

It means there were 188056ms (~3min) between the requested shutdown and the listener socket being created.  There is no crash report, so not sure what's going on here.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We do no longer restart Firefox to enforce a preference. As such the failure has been changed, and seems to be permanently visible for tests against Fennec.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The failures seem to only be present for modal dialogs but not tab modal dialogs, and happen when clicking it:

[task 2017-01-09T10:31:11.708353Z] 10:31:11     INFO -      self.marionette.find_element(By.ID, 'modal-alert').click()
[task 2017-01-09T10:31:11.708447Z] 10:31:11     INFO -    File "/home/worker/workspace/build/venv/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 82, in click
[task 2017-01-09T10:31:11.708521Z] 10:31:11     INFO -      self.marionette._send_message("clickElement", {"id": self.id})

The issue for Fennec here is that the test stops once the modal dialog opens. There is no reply coming back for the click command and as such we hang until the socket timeout.

For now I will just disable the modal dialog tests and leave the tab modals running. I may have to restructure the tests for that.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As it looks like it doesn't matter which preference value is set, the dialogs always end up as modal dialogs. Maybe Fennec doesn't support tab modal dialogs? For now I'm going to skip the full test module for Fennec.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1325738 - Skip test_modal_dialogs.py for Fennec

As testing has been shown the execution of Marionette server is blocked when
a new dialog popsup. Given that Fennec seems to only support modal dialogs, the
full test module has to be skipped for now.

Review commit: https://reviewboard.mozilla.org/r/103816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103816/

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8825731 [details]
Bug 1325738 - Skip test_modal_dialogs.py for Fennec

https://reviewboard.mozilla.org/r/103816/#review104550

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb30cfd7f4e7
Skip test_modal_dialogs.py for Fennec r=maja_zf

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb30cfd7f4e7

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reopening bug given that the patch which landed simply disabled the tests until a proper solution is in place.

Can you please uplift to aurora? Thanks.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e06ca5fc05b8

Comment 11

[David Burns :automatedtester]

Closing as intermittent has not been seen in last 45 days

Comment 12

[David Burns :automatedtester]

This is not an intermittent, looks like a missing feature

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Nothing is fixed here. The test is still disabled.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The problem is that for Fennec we have a custom prompt implementation, which can be found here:
https://searchfox.org/mozilla-central/source/mobile/android/modules/Prompt.jsm

Because of that we aren't able yet to detect those prompts because they are different than modal dialogs or tab modals in Firefox.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fennec is no longer supported, and for GeckoView the code should be completely different. As such we don't want to fix this bug.