1325816 - "Change search settings" button appears in a new line instead of the same line as other search providers if DPI > 125%

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Itiel]

Attachment: Not enough room for the settings icon- on RTL builds

See attached screenshot.
It seems as if there's not enough room for the settings icon to appear on the left of the separator.

This issue possibly occurs only on RTL builds.

Comment 1

[Tomer Cohen :tomer]

(In reply to ItielMaN from comment #0)
> This issue possibly occurs only on RTL builds.
Can you please attach the LTR equivalent to the RTL screenshot? Thanks.

Comment 2

[Itiel]

Attachment: On LTR build

(In reply to Tomer Cohen :tomer from comment #1)
> (In reply to ItielMaN from comment #0)
> > This issue possibly occurs only on RTL builds.
> Can you please attach the LTR equivalent to the RTL screenshot? Thanks.

Well what do you know. The same applies to LTR builds.

Comment 3

[Tomer Cohen :tomer]

Attachment: Screenshot

Unable to reproduce on my machine. Could be a resolution issue?

Comment 4

[Itiel]

Things just keep getting intereseting.
I'm running Windows 10 with 1920x1080 resolution, and 150% DPI scaling on a 24" monitor.
Changing the DPI to 125% or 100% fixes the issue.
So, this is a DPI-related issue.

See also bug 1206709.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Bumping up the priority cause this also causes popup contents jumping (bug 1326235)

Comment 6

[Dinarte Jesus [:jdj]]

[::mark] I'm able to reproduce and isn't only on LTR Builds but also when you copy and paste full URL to the awesome bar.
 
Steps to display issue:
 1 Copy a full URL or a text and paste on the awesome bar.
 2 Browser create 6 empty buttons "searchbar-engine-one-off-item dummy"
 3 Settings buttons Goes in the wrong position

Steps to work normally:
 1 start typing anything on the awesome bar
 2 Browser create only 5 empty buttons "searchbar-engine-one-off-item dummy"
 3 Settings goes in the right place

PS: I'm running my Nightly on Mac

[::mark] Maybe you could assign the bug to me, I'll try to fix it.

Comment 7

[Dinarte Jesus [:jdj]]

UPDATE: On my Mac this only happens because I've Test Pilot Tab Center active.

Comment 8

[Itiel]

Fixed by bug 1316566.

Comment 9

[Simona Badau, Desktop QA]

I tried to verify this, but I can't reproduce the initial issue. 

ItielMaN, could you please confirm that this issue is fixed on your side?

Comment 10

[Itiel]

(In reply to Simona B [:simonab ] from comment #9)
> I tried to verify this, but I can't reproduce the initial issue. 
> 
> ItielMaN, could you please confirm that this issue is fixed on your side?

Yes it is.
Closing as VERIFIED FIXED.