1325897 - Unship some Universal CRT DLLs

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

Many (but not all) of api-ms-win-core-*.dlls are needed only for Windows Vista or earlier.

Comment 1

[mirh]

https://support.microsoft.com/en-us/kb/2999226
Just for the records, every dll 7 has seems to be on Vista as well.

Comment 2

[Masatoshi Kimura [:emk]]

Only if the Update for Universal C Runtime is applied. We can't assume updates are applied unless System Requirements require it explicitly (e.g. SP2 was needed for Windows XP). We have not mandated any updates to Windows Vista.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: non-working patch

Hm, glob and set are not available in the moz.build sandbox...

Comment 4

[Gregory Szorc [:gps]]

set() may not be available, but you can use a set literal comprehension to create one:

  {x for x in iterable}

(I'm not opposed to exposing set() to the sandbox - it is a very useful primitive.)

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Bug 1325897 - Unship some Universal CRT DLLs.

Review commit: https://reviewboard.mozilla.org/r/101316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101316/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8822376 [details]
Bug 1325897 - Unship some Universal CRT DLLs.

https://reviewboard.mozilla.org/r/101316/#review104372

I'm inclined to say we shouldn't do this without ensuring we're not shooting ourselves in the foot in the future. That is, we should have tests in place that ensure that
a) we are not including in this list things that we don't need
b) we don't start using things that are not in this list

Comment 7

[Masatoshi Kimura [:emk]]

I considered using dependentlibs.py and filed a found bug (1330192).

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: Bug 1325897 - Unship some Universal CRT DLLs. r=dmajor,glandium

Comment 9

[Masatoshi Kimura [:emk]]

Try runs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=657b1f1c9d661dc8286ddff1170bb8fc1c3c4fbe
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43505f63e1f6db8633aa30afd1eec12cc962f720 (fails if extra files are in appdir)
Win32 SM builds are broken regardless of this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99de0bfedd486b7df6ae1cac83e44df239051fea

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9567622873d6
Unship some Universal CRT DLLs. r=dmajor

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out changeset 9567622873d6 (Bug 1325897) for causing Toolchains stackwalks bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=9567622873d62601425b04227642048475fa6137&searchStr=stackwalk&fromchange=48d248c9f5fdddf38e15a155b6101a0319db592a&selectedJob=237484218

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237484219&repo=autoland&lineNumber=671

Backout: https://hg.mozilla.org/integration/autoland/rev/3305707514a18ff272af09a9e426819b9b47dc6a

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73e57709c5ee
Unship some Universal CRT DLLs. r=dmajor,glandium

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/73e57709c5ee