Closed Bug 1325897 Opened 3 years ago Closed 8 months ago

Unship some Universal CRT DLLs

Categories

(Firefox Build System :: General, defect)

Unspecified
Windows
defect
Not set

Tracking

(firefox53 wontfix, firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox53 --- wontfix
firefox68 --- fixed

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Many (but not all) of api-ms-win-core-*.dlls are needed only for Windows Vista or earlier.
https://support.microsoft.com/en-us/kb/2999226
Just for the records, every dll 7 has seems to be on Vista as well.
Only if the Update for Universal C Runtime is applied. We can't assume updates are applied unless System Requirements require it explicitly (e.g. SP2 was needed for Windows XP). We have not mandated any updates to Windows Vista.
Attached patch non-working patch (obsolete) — Splinter Review
Hm, glob and set are not available in the moz.build sandbox...
set() may not be available, but you can use a set literal comprehension to create one:

  {x for x in iterable}

(I'm not opposed to exposing set() to the sandbox - it is a very useful primitive.)
Attachment #8822037 - Attachment is obsolete: true
Comment on attachment 8822376 [details]
Bug 1325897 - Unship some Universal CRT DLLs.

https://reviewboard.mozilla.org/r/101316/#review104372

I'm inclined to say we shouldn't do this without ensuring we're not shooting ourselves in the foot in the future. That is, we should have tests in place that ensure that
a) we are not including in this list things that we don't need
b) we don't start using things that are not in this list
Attachment #8822376 - Flags: review?(mh+mozilla)
I considered using dependentlibs.py and filed a found bug (1330192).
No longer blocks: xp-eol
Depends on: xp-eol
Blocks: xp-eol
No longer depends on: xp-eol
Product: Core → Firefox Build System
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8822376 - Attachment is obsolete: true
Attachment #9051513 - Attachment description: Bug 1325897 - Unship some Universal CRT DLLs. r?glandium → Bug 1325897 - Unship some Universal CRT DLLs. r?dmajor
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9567622873d6
Unship some Universal CRT DLLs. r=dmajor
Attachment #9051513 - Attachment description: Bug 1325897 - Unship some Universal CRT DLLs. r?dmajor → Bug 1325897 - Unship some Universal CRT DLLs. r=dmajor,glandium
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/73e57709c5ee
Unship some Universal CRT DLLs. r=dmajor,glandium
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(VYV03354)
Regressions: 1542735
You need to log in before you can comment on or make changes to this bug.