Closed Bug 1542735 Opened 5 years ago Closed 5 years ago

"toolkit/library/gtest/static/TestUCRTDepends.cpp(10,10): fatal error: 'gtest/gtest.h' file not found" bustage with --disable-tests

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1542735 - Don't try to build TestUCRTDepends if tests are disabled. r=dmajor
47 bytes, text/x-phabricator-request
Details | Review

toolkit/library/gtest/static/TestUCRTDepends.cpp(10,10): fatal error: 'gtest/gtest.h' file not found
#include "gtest/gtest.h"
^~~~~~~~~~~~~~~

Looks like there's no ENABLE_TESTS guard for the newly-added test from bug 1325897.

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8c67ca7b3d9
Don't try to build TestUCRTDepends if tests are disabled. r=froydnj

https://hg.mozilla.org/mozilla-central/rev/c8c67ca7b3d9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: