1326101 - Write unit tests for GeckoBundle

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Write unit tests for GeckoBundle that tests its basic functionality as well as its unique features such as automatic conversion between double and int.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1326101 - 1. Add unit test for GeckoBundle;

Add a unit test for GeckoBundle, which tests GeckoBundle more thoroughly
than testEventDispatcher. This also lets us remove the Parcelable test
from testEventDispatcher.

Review commit: https://reviewboard.mozilla.org/r/216260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216260/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1326101 - 2. Fix some GeckoBundle bugs;

Fix some GeckoBundle tests uncovered by the new unit test.

Review commit: https://reviewboard.mozilla.org/r/216262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216262/

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8946294 [details]
Bug 1326101 - 1. Add unit test for GeckoBundle;

https://reviewboard.mozilla.org/r/216260/#review222536

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8946295 [details]
Bug 1326101 - 2. Fix some GeckoBundle bugs;

https://reviewboard.mozilla.org/r/216262/#review222538

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f676e27cc145
1. Add unit test for GeckoBundle; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/22a2b0f1b1ab
2. Fix some GeckoBundle bugs; r=snorp

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f676e27cc145
https://hg.mozilla.org/mozilla-central/rev/22a2b0f1b1ab