Closed Bug 1433322 Opened 4 years ago Closed 4 years ago

[geckoview] Move GeckoView unit tests to under geckoview/

Categories

(GeckoView :: General, enhancement)

Product:
GeckoView
Component:
General
Version:
58 Branch
Platform:
Unspecified
Android
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(3 files)

Bug 1433322 - 1. Move publicsuffix utils to under Fennec;
59 bytes, text/x-review-board-request
nalexander
: review+
Details
Bug 1433322 - 2. Mass move GeckoView unit tests to under geckoview/;
59 bytes, text/x-review-board-request
nalexander
: review+
Details
Bug 1433322 - 3. Run GeckoView unit tests with 'mach android test';
59 bytes, text/x-review-board-request
nalexander
: review+
Details 
Right now we have some unit tests under Fennec that really belong in GeckoView because they test GeckoView code.
Comment on attachment 8945640 [details]
Bug 1433322 - 1. Move publicsuffix utils to under Fennec;

https://reviewboard.mozilla.org/r/215770/#review221498

This will fail, since moz.build still exists -- so that needs to be addressed.  But I think this is the right home for this functionality!
Attachment #8945640 - Flags: review?(nalexander) → review+
Comment on attachment 8945641 [details]
Bug 1433322 - 2. Mass move GeckoView unit tests to under geckoview/;

https://reviewboard.mozilla.org/r/215772/#review221500

I don't quite follow the test runner details, but I'm happy for you to own this!
Attachment #8945641 - Flags: review?(nalexander) → review+
Comment on attachment 8945642 [details]
Bug 1433322 - 3. Run GeckoView unit tests with 'mach android test';

https://reviewboard.mozilla.org/r/215774/#review221502

As usual, r- is f+.

Three things:

1) my guess is that test failures don't print anything right now, since https://searchfox.org/mozilla-central/source/mobile/android/mach_commands.py#86 needs to be enlarged.  You can test this by introducing failures and running |mach android test| locally.
2) https://searchfox.org/mozilla-central/source/taskcluster/ci/build/android-stuff.yml#19 needs to be enlarged, so that reports are shared.
3) this will conflict a little with my patches for https://bugzilla.mozilla.org/show_bug.cgi?id=1411654, which I'm working hard to get landed.  In particular, those patches change some of the variant names, and update the Robolectric bits.  Can you try to build on top of that series?

Thanks for digging in!
Attachment #8945642 - Flags: review?(nalexander) → review-
Comment on attachment 8945642 [details]
Bug 1433322 - 3. Run GeckoView unit tests with 'mach android test';

https://reviewboard.mozilla.org/r/215774/#review223122

Thanks for catching some errors, which I no doubt introduced in my 3.0 patch!  I'm going to be more careful about empty input sets in the future, 'cuz you make a good point.  Bombs away!
Attachment #8945642 - Flags: review?(nalexander) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7862b1b5e9b
1. Move publicsuffix utils to under Fennec; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a74b6699ff3
2. Mass move GeckoView unit tests to under geckoview/; r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/e91adf8f9294
3. Run GeckoView unit tests with 'mach android test'; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/f7862b1b5e9b
https://hg.mozilla.org/mozilla-central/rev/0a74b6699ff3
https://hg.mozilla.org/mozilla-central/rev/e91adf8f9294
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → GeckoView
Version: Firefox 58 → 58 Branch
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.